auth: once again, relax JSON normalization code for record contents#17373
Open
miodvallat wants to merge 3 commits into
Open
auth: once again, relax JSON normalization code for record contents#17373miodvallat wants to merge 3 commits into
miodvallat wants to merge 3 commits into
Conversation
…ents. parseRFC1035CharString will always reject ( ) and ;, the latter which is quite often used. The new parseRFC1035CharStringRelaxed automaton behaves similarly to parseRFC1035CharString, but allows these three characters when they appear within quoted sections. Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Fixes PowerDNS#17368 Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Coverage Report for CI Build 25920986031Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage at 71.091% (no base build to compare)Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
As mentioned in #17368, the recent addition of normalization for the RRset contents fed through the API will reject semicolons in valid
TXTrecords.This PR replaces the use of
parseRFC1035CharStringin this code path with a slightly differentparseRFC1035CharStringRelaxed. The only difference between these routines is that the relaxed form will now accept()and;, if they occur within a"-quoted part.Checklist
I have: