Skip to content

pull_request_template.md

Latest commit

 

History

History
66 lines (45 loc) · 2.25 KB

pull_request_template.md

File metadata and controls

66 lines (45 loc) · 2.25 KB
Raw

Summary

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (renames, removed/changed exported names, behaviour change visible to SDK consumers)
  • Documentation only
  • CI / repository hygiene

Related issues

What I tested

go build ./... && go vet ./... && go test ./... && gofmt -l .
  • Output of the above is clean on my machine
  • New code paths have unit tests, or the PR description explains why a test isn't reasonable

Cross-platform parity

  • No runtime.GOOS branches added outside pattern/neolab (or, if added, justified in the PR description)
  • Builds on linux/amd64, linux/arm64, darwin/arm64, windows/amd64 (CI cross-build job will catch this; tick after CI passes)

Public API impact

  • Added:
  • Removed:
  • Signature-changed:

Licence acknowledgement

  • I understand that my contribution is released under Apache-2.0 (see LICENSE)
  • I am aware that binaries built from this SDK incur an AGPL-3.0 transitive obligation via go-fitz/MuPDF, and my change does not silently introduce additional licence-incompatible dependencies

Notes for the reviewer