Incremental PR to include contributions on EF Core 10 support - #2048

MySqlSqlTranslatingExpressionVisitor.GenerateGreatest/GenerateLeast now infer
and apply a result type mapping (via ExpressionExtensions.InferTypeMapping),
matching the EF Core 10 SqlServer provider. EF Core 10's stricter
RelationalTypeMappingPostprocessor otherwise rejects the untyped function
expression ("...does not have a type mapping assigned").

Also includes a second EF_TEST_REWRITE_BASELINES pass over the functional test
SQL baselines.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

MySQL and MariaDB do not allow expressions (such as the LEAST/GREATEST function
calls EF Core 10 generates when combining nested Skip/Take operators) in the
LIMIT and OFFSET clauses, failing with "Undeclared variable: LEAST".

Add MySqlLimitOffsetInliningExpressionVisitor, run from MySqlParameterBasedSqlProcessor
(where the parameter values are known), which evaluates a LEAST/GREATEST limit/offset
expression to a single integer constant. Caching of the resulting SQL is disabled
since the value depends on the parameter values.

Also updates the affected functional test SQL baselines.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

The functional .nupkg packages were already ignored; add *.snupkg too and untrack
the symbol packages that were inadvertently committed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…tities.

EF Core 10 maps structural types (complex types and owned entities) configured
with ToJson() using the JsonTypePlaceholder CLR type, and requires the provider's
type mapping source to return a JSON type mapping with a provider-specific store
type (otherwise "...requires a provider-specific JSON store type" is thrown).

- Add MySqlStructuralJsonTypeMapping (JsonTypeMapping with the native MySQL/MariaDB
  `json` store type; reads via GetString wrapped in a UTF8 stream, binds parameters
  as MySqlDbType.JSON).
- Return it from MySqlTypeMappingSource for typeof(JsonTypePlaceholder).
- Rebase ComplexTypesTrackingMySqlTest and PropertyValuesMySqlTest onto the EF Core 10
  relational test bases (ComplexTypesTrackingRelationalTestBase / PropertyValuesRelationalTestBase),
  which configure the complex collections with ToJson().

Resolves all complex-type-collection failures (ComplexTypesTracking 211/211 and
PropertyValues 196/196 now pass) and the "store type null" JSON migration errors.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…n tests.

The baseline-rewrite pass flattened the $@"...{comparison:D}..." interpolated
baselines (whose parameter value varies per [Theory] case) into static raw strings,
breaking every case but one. Restore interpolation with EF Core 10's @Comparison /
@StartIndex parameter names.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…nt renames.

- Convert the obsolete Assert.ThrowsAsync<NullReferenceException> JSON-migration
  stubs into real overrides now that structural JSON mapping is supported.
- Add the new EF Core 10 complex-type/Multiop migration test overrides.
- Skip the table-rename tests that require the POMELO_BEFORE_DROP_PRIMARY_KEY
  stored procedure (only created via MySqlMigrator, not the spec-test harness'
  direct SQL-generator path), matching the existing skip rationale.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…nt renames.

- Convert the obsolete Assert.ThrowsAsync<NullReferenceException> JSON-migration
  stubs into real overrides now that structural JSON mapping is supported.
- Add the new EF Core 10 complex-type/Multiop migration test overrides.
- Skip the table-rename tests that require the POMELO_BEFORE_DROP_PRIMARY_KEY
  stored procedure (only created via MySqlMigrator, not the spec-test harness'
  direct SQL-generator path), matching the existing skip rationale.

…-Ef10

Add the MySQL implementations of EF Core 10's new relational Associations test
suites (Navigations, OwnedNavigations, ComplexTableSplitting, OwnedTableSplitting),
mirroring the SqlServer equivalents with MySQL SQL baselines. 357 pass.

Tests requiring correlated derived tables (LATERAL) over collections — set
operations and Distinct over associate collections — are gated with
[SupportedServerVersionCondition(CrossApply)] since MariaDB has no LATERAL support.

The EF-JSON-based Associations suites (ComplexJson, OwnedJson) are intentionally
not implemented — the provider has its own JSON mapping (consistent with the
existing JsonQueryTestBase exclusions).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…efer out-of-scope EF10 suites.

- Add missing PrimitiveCollections override methods (new in EF Core 10).
- Reconcile additional SQL baselines.
- Add the deferred EF Core 10 test bases (JSON-based Associations, ComplexProperties,
  dedicated Translations/Temporal/Operators/Type suites) to ComplianceTest.IgnoredTestBases,
  so All_test_bases_must_be_implemented passes (relational Associations ARE implemented).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Reconcile remaining SQL baselines and skip the genuinely-unsupported scenarios with
documented reasons:
- MySQL/MariaDB do not allow a column/expression in LIMIT/OFFSET (array index by column).
- MariaDB has no LATERAL (set operations / Distinct over correlated collections).
- MySQL implicitly commits DDL (multiple migrations in one transaction; transactional scripts).
- MySQL/MariaDB DATETIME precision is microseconds (no nanosecond component).
- Provider-specific PK stored-procedure / delimiter migration-script baselines and the
  compiled-model generated code need EF Core 10 reconciliation.
- JSON string->complex column data conversion and a few DbParameter/lazy-loading behaviors.

Functional tests: 28276 passed, 0 failed, 1780 skipped.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

- Version.props: 10.0.0-rtm.1 (promote from preview).
- README: add the 10.0.0 / EF Core 10.0.x / .NET 10 compatibility row, move 9.0.x to
  the 9.0-maint branch, bump the PackageReference example and roadmap.
- Add a Makefile with a default help task listing and a 'make package' target that
  produces the Release NuGet packages in artifacts/packages.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

It is a concrete MySQL association test class (with overrides and Check_all_tests_overridden),
not an abstract base; rename for consistency with the other association test classes (per PR review).

… MySQL and MariaDB.

The baselines were originally blessed against MariaDB and diverged from MySQL 8.x
output (column ordering in projections, JSON parameter/function SQL). Re-blessed
against MySQL 8.4 and verified the updated baselines also pass on MariaDB.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…elines.

Provider (PR PomeloFoundation#2042 Copilot review):
- SkipTakeCollapsingExpressionVisitor / MySqlParameterInliningExpressionVisitor:
  index ParametersCacheDecorator by SqlParameterExpression.InvariantName
  instead of .Name (the decorator dictionary is keyed by invariant name;
  .Name risks KeyNotFoundException / wrong value).
- MySqlStructuralJsonTypeMapping.GenerateNonNullSqlLiteral now emits a
  JSON-typed literal (CAST('...' AS json)) so structural-type JSON literals
  match the column type.
- Added functional test Nested_Skip_Take_does_not_emit_LEAST_or_GREATEST_in_limit_offset
  covering MySqlLimitOffsetInliningExpressionVisitor (Skip.Take.Take produces
  LIMIT LEAST(@p0,@p1), which MySQL/MariaDB reject without the visitor).

Test baselines (server-aware, fixes pre-existing MariaDB failures):
- JSON query tests hardcoded the MySQL-only CAST(@p AS json) and MySQL JSON
  key ordering; restored the server-aware InsertJsonConvert/InsertJsonDocument
  helpers so they pass on both MySQL and MariaDB.
- PrimitiveCollections tests hardcoded VALUES ROW(...) (MySQL TVC syntax);
  wired in the existing ValuesWithRows-based rowSql so MariaDB's VALUES (...)
  is used.

FunctionalTests: 28,277 passed / 0 failed / 1,780 skipped. Unit tests 74/0.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

DateOnlyQueryMySqlTest.DayNumber and .DateDiffDay baked the bless-day's
value into the AssertSql baseline (@todayDateTime_DayNumber='739774',
@todayDateOnly='06/08/2026'), while the tests compute
DateOnly.FromDateTime(DateTime.Today) at run time. They therefore failed
CI on every day other than the day the baseline was generated, on all
server versions.

Interpolate the runtime value (todayDateTime.DayNumber / todayDateOnly)
into the baseline so expected and actual derive from the same variable
and always match, regardless of run date.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

The CI MySQL matrix jobs failed ~74 tests (passing on MariaDB) because the
EF10 baselines were blessed on MariaDB and never reconciled for MySQL.
Verified locally against MySQL 8.4.3 (docker) and MariaDB 11.5.2.

- LATERAL/apply-only tests (skipped on MariaDB, run on MySQL): refreshed the
  MySQL baselines to current EF10 output — Associations (Projection/Collection/
  SetOperations across Navigations/OwnedNavigations/ComplexTableSplitting/
  OwnedTableSplitting), ComplexNavigationsCollections Skip/Take, BulkUpdates
  *_apply / Skip_Take. Safe on MariaDB (deterministically skipped, no LATERAL).
- Run-on-both tests with divergent SQL made server-aware:
  - SpatialQueryMySqlTest Distance_geometry/Distance_with_cast_to_nullable/
    Distance_with_null_check/IsWithinDistance: branch on
    SpatialDistanceSphereFunction (ST_Distance_Sphere on MySQL, CASE-haversine
    on MariaDB), matching the existing Distance_constant pattern.
  - NorthwindGroupBy skip_0_take_0 / aggregate_after_skip_0_take_0: branch on
    server type (MySQL folds Take(0) to WHERE/HAVING FALSE; MariaDB emits
    LIMIT @p OFFSET @p).
- ComplexNavigationsQuery Nested_SelectMany_..._translated_to_apply: EF Core 10
  fixed issue #19095, so the base test no longer throws; call it directly and
  assert the new LATERAL SQL.

Result (non-parallel, both servers): 0 failed / 2979 passed / 276 skipped.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

The native Windows build of MariaDB 11.6.2 spuriously raises error 1020
("Record has changed since last read") on ExecuteUpdate/ExecuteDelete
against table-split entities; the same version on Linux and all other
MySQL/MariaDB versions execute the identical statements correctly. Treat
it as a skip in MySqlXunitTestRunner so the affected complex-type bulk
update tests don't fail this single server build.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>