fix(tags): updating ops-cli to always include tags - #20
Merged
Conversation
bassrock
marked this pull request as ready for review
June 21, 2023 04:20
Contributor
Author
|
Tested on https://github.com/Pocket/Web/pull/4568 |
izo3
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Web repo feature deploys have been failing for a while after a first deploy with the following error:
This is because ops-cli needs to register a new task definition on a branch update that duplicates the original creation. AWS however during this creation will not allow an empty
tagsarray.The command where we grab the old task via RegisterTaskDefintion used to return Tags that were on the Task Definition by default. At some point it appears AWS changed this defintion and now it states:
To solve for this we now specifically request them