fix(hidpp20): HiresScroll::getRatchetState reads response, not params#546
Open
jelmerdehen wants to merge 1 commit into
Open
fix(hidpp20): HiresScroll::getRatchetState reads response, not params#546jelmerdehen wants to merge 1 commit into
jelmerdehen wants to merge 1 commit into
Conversation
getRatchetState was returning params[0] from a freshly-constructed empty vector. This produced an out-of-bounds read on every call and always returned a meaningless value regardless of what the device reported. Read response[0] instead, with an empty-response guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HiresScroll::getRatchetStatereturnedparams[0]from a freshly-constructed emptystd::vector. This produced an out-of-bounds read on every call and always returned a meaningless value regardless of what the device reported.Fix
Read
response[0]and guard against an empty response.Test plan
[[maybe_unused]]and not called anywhere in tree, so no behavioural test exists; verified by inspection.