fix(gui): stop hiding extensionless vaults in the create-vault picker#15
Open
mvanhorn wants to merge 1 commit into
Open
fix(gui): stop hiding extensionless vaults in the create-vault picker#15mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
Contributor
|
Hello @mvanhorn, Did you have issues to open an existing vault without the extension on the v0.2.2? Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The create-vault Browse picker no longer filters to
*.lbx, so vaults at extensionless paths (the old default name wassecret) can be created and reselected like any other file. This was the last picker still carrying anadd_filter("LUKSbox vault", &["lbx"])call -open_existing_pickerand the unlock-view Browse handler already dropped their filters with a documented rationale.Why this matters
#12 has two users (devoid1, Hxs2fJKjYZ) who cannot work with extensionless vaults through the GUI, and you noted you would fix the extension handling. The codebase already documents why no filter variant works cross-platform (the comment block in
open_existing_picker:&["lbx"]hides extensionless files,&["*"]becomes a*.*glob on Linux xdg-desktop-portal,&[]is portal-dependent). This change applies that same convention to the one remaining inconsistent site, the create-vaultsave_file()dialog incrates/luksbox-gui/src/app.rs, with a short comment pointing at the rationale.Testing
cargo check -p luksbox-gui --no-default-featurespasses (hardware/fuse features need macFUSE + libfido2, not available on this machine; the change is GUI-only)cargo fmt -p luksbox-gui -- --checkcleanFixes #12