fixes the conflation of soil and microbial maintenance respiration by splitting it #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushman1210
requested review from
Alomir,
dlebauer,
infotroph,
mdietze and
mswilburn
as code owners
Alomir
requested changes
Dec 10, 2025
Collaborator
Alomir
left a comment
Alomir
left a comment
There was a problem hiding this comment.
Thanks for putting this together, @ayushman1210! It's almost there, I have a few additions that should be made.
Contributor
Author
|
hey @Alomir i have made as per your suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This update fixes the conflation of soil and microbial maintenance respiration by splitting
maintRespirationinto:soilMaintRespirationmicrobeMaintRespirationIt also corrects the respiration temperature formulation by separating the base rate from the Q10 temperature effect.
Key Changes
maintRespirationwith explicit soil and microbe maintenance fluxes.rSoilcalculation:rSoil = soilMaintRespirationrSoil = microbeMaintRespiration + (1 - microbeEff) * microbeIngestionstate.hto match new flux definitions.Testing
--microbes[success]sipnet.out) generated successfully [success]Fixes #144