-
Notifications
You must be signed in to change notification settings - Fork 18
Reformulation of nitrogen fixation: dependent on plant N uptake and availability of Nmin #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remove t dependence of N fixation. N fixation is proportional to NPP, which itself is proportional to temperature. I did not find evidence for other models using T dependence.
docs/model-structure.md
Outdated
| $$ | ||
|
|
||
| Nitrogen fixation is represented by adding fixed nitrogen directly to the soil mineral nitrogen pool. This is a reasonable first approximation, consistent with the simplicity of the nitrogen limitation model where limitation only occurs when nitrogen demand exceeds supply. | ||
| <!-- do parameter estimates / ranges go in this doc? in the params doc? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this would be great in the params doc
Alomir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Might want to put the parameter estimate into the params doc, but that can be here in this PR or elsewhere
…N demand modified by Nmin availability
…dit N fixation / N demand description
…I changed some \eqref to \ref
|
@Alomir RE:
I changed the formulation since that note, so didn't carry over this particular value, but drafted a document for priors and default values in #194 so that next time there would be a place to take notes. |
Alomir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll be able to take a better look when it's published, but let's get this in.
infotroph
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working this up.
Approving to keep the process moving, but I'm staking my prediction that this approach will need to be modified to include an explicit carbon cost of N fixation.
In a Slack discussion @dlebauer says that's handled implicitly by fixed C:N ratios making autotrophic respiration scale with N supply (when N is limiting), but I still don't see it -- my reading is the equations here will impose the same cost per unit N whether it comes from fixation or not. One or the other of us will get a told-you-so eventually 😉
|
@infotroph You’re right that this formulation dosn't include an explicit carbon cost of fixation; the cost is implicit through higher N demand for legumes (via plant C:N) and because fixation can only supply a fraction of demand up to a maximum. There are other ways to represent N fixation, and we can consider those if validation and uncertainty analysis suggest that this formulation is insufficient, focusing on the CA cropland use case. If you have a specific functional form and validation datasets in mind, please write those in a separate issue and / or PR. |
|
If we want to add a C cost of N fixation, there are existing schemes out there we can borrow, e.g. https://doi.org/10.1029/2022MS003204. And I agree with Chris that the cost of fixation goes above and beyond the more general cost of N uptake, though I feel like many models don't explicitly model the latter, but just lump it into the more general concept of growth respiration. |
I worked through a few ways of representing this and didn't come up with a suitable solution, not that one doesn't exist. The ELM-FUN approach is interesting and it is great to see mechanistic representation of N and P limitation in ESMs. Notably, N limitation is relatively less important in croplands, and the paper suggests that the proposed representation is already more realistic than most ESMs. |
Replace N fixation as f(NPP) with N fixation = f(N demand, N availability).
Any further modifications, other than reversion to N_fix = a * NPP, should be proposed as a separate pull request.
Highlights (from rendered model-structure.md):