Skip to content

Conversation

@dlebauer
Copy link
Member

@dlebauer dlebauer commented Nov 19, 2025

Replace N fixation as f(NPP) with N fixation = f(N demand, N availability).

  • Fixed N goes directly to plant
  • Add parameters nFixFracMax and nFixHalfSatMinN
  • unify N-cycle params table.
  • Docs only; no code changes.

Any further modifications, other than reversion to N_fix = a * NPP, should be proposed as a separate pull request.

Highlights (from rendered model-structure.md):

image image

remove t dependence of N fixation.
N fixation is proportional to NPP, which itself is proportional to temperature. 
I did not find evidence for other models using T dependence.
@dlebauer dlebauer requested review from Alomir and mswilburn November 19, 2025 04:36
@dlebauer dlebauer mentioned this pull request Nov 19, 2025
6 tasks
$$

Nitrogen fixation is represented by adding fixed nitrogen directly to the soil mineral nitrogen pool. This is a reasonable first approximation, consistent with the simplicity of the nitrogen limitation model where limitation only occurs when nitrogen demand exceeds supply.
<!-- do parameter estimates / ranges go in this doc? in the params doc?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this would be great in the params doc

Copy link
Collaborator

@Alomir Alomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Might want to put the parameter estimate into the params doc, but that can be here in this PR or elsewhere

@dlebauer dlebauer changed the title Remove T dependence of nitrogen fixation model and add references Reformulation of nitrogen fixation: dependent on plant N uptake and availability of Nmin Nov 20, 2025
@dlebauer
Copy link
Member Author

@Alomir RE:

Might want to put the parameter estimate into the params doc, but that can be here in this PR or elsewhere

I changed the formulation since that note, so didn't carry over this particular value, but drafted a document for priors and default values in #194 so that next time there would be a place to take notes.

Copy link
Collaborator

@Alomir Alomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll be able to take a better look when it's published, but let's get this in.

Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working this up.

Approving to keep the process moving, but I'm staking my prediction that this approach will need to be modified to include an explicit carbon cost of N fixation.

In a Slack discussion @dlebauer says that's handled implicitly by fixed C:N ratios making autotrophic respiration scale with N supply (when N is limiting), but I still don't see it -- my reading is the equations here will impose the same cost per unit N whether it comes from fixation or not. One or the other of us will get a told-you-so eventually 😉

@dlebauer
Copy link
Member Author

dlebauer commented Dec 2, 2025

@infotroph You’re right that this formulation dosn't include an explicit carbon cost of fixation; the cost is implicit through higher N demand for legumes (via plant C:N) and because fixation can only supply a fraction of demand up to a maximum.

There are other ways to represent N fixation, and we can consider those if validation and uncertainty analysis suggest that this formulation is insufficient, focusing on the CA cropland use case.

If you have a specific functional form and validation datasets in mind, please write those in a separate issue and / or PR.

@mdietze
Copy link
Member

mdietze commented Dec 2, 2025

If we want to add a C cost of N fixation, there are existing schemes out there we can borrow, e.g. https://doi.org/10.1029/2022MS003204. And I agree with Chris that the cost of fixation goes above and beyond the more general cost of N uptake, though I feel like many models don't explicitly model the latter, but just lump it into the more general concept of growth respiration.

@dlebauer
Copy link
Member Author

dlebauer commented Dec 3, 2025

cost of fixation goes above and beyond the more general cost of N uptake ... just lump it into the more general concept of growth respiration.

I worked through a few ways of representing this and didn't come up with a suitable solution, not that one doesn't exist.

The ELM-FUN approach is interesting and it is great to see mechanistic representation of N and P limitation in ESMs. Notably, N limitation is relatively less important in croplands, and the paper suggests that the proposed representation is already more realistic than most ESMs.

@dlebauer dlebauer merged commit 0976191 into master Dec 3, 2025
10 of 11 checks passed
@dlebauer dlebauer deleted the n-fix-update branch December 3, 2025 01:12
@dlebauer dlebauer mentioned this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants