Fix: Ensure settings$database defaults to NULL when absent

AritraDey-Dev · AritraDey-Dev · commit 4dd3af9d08c1 · 2025-12-10T17:09:00.000+05:30
Signed-off-by: Aritra Dey &lt;adey01027@gmail.com&gt;
diff --git a/base/settings/R/check.all.settings.R b/base/settings/R/check.all.settings.R
@@ -450,25 +450,27 @@ check.settings <- function(settings, force = FALSE) {
   }
 
   # Check folder where outputs are written before adding to dbfiles
-  if (is.null(settings$database$dbfiles)) {
-    settings$database$dbfiles <- PEcAn.utils::full.path("~/.pecan/dbfiles")
-  } else {
-    if (substr(settings$database$dbfiles, 1, 1) != "/") {
-      PEcAn.logger::logger.warn(
-        "settings$database$dbfiles pathname", settings$database$dbfiles,
-        "is invalid\n",
-        "placing it in the home directory ",
-        Sys.getenv("HOME"))
-      settings$database$dbfiles <- file.path(
-        Sys.getenv("HOME"),
-        settings$database$dbfiles)
-    }
+  if (!is.null(settings$database)) {
+    if (is.null(settings$database$dbfiles)) {
+      settings$database$dbfiles <- PEcAn.utils::full.path("~/.pecan/dbfiles")
+    } else {
+      if (substr(settings$database$dbfiles, 1, 1) != "/") {
+        PEcAn.logger::logger.warn(
+          "settings$database$dbfiles pathname", settings$database$dbfiles,
+          "is invalid\n",
+          "placing it in the home directory ",
+          Sys.getenv("HOME"))
+        settings$database$dbfiles <- file.path(
+          Sys.getenv("HOME"),
+          settings$database$dbfiles)
+      }
 
-    settings$database$dbfiles <- normalizePath(
-      settings$database$dbfiles,
-      mustWork = FALSE)
+      settings$database$dbfiles <- normalizePath(
+        settings$database$dbfiles,
+        mustWork = FALSE)
+    }
+    dir.create(settings$database$dbfiles, showWarnings = FALSE, recursive = TRUE)
   }
-  dir.create(settings$database$dbfiles, showWarnings = FALSE, recursive = TRUE)
 
   # check all inputs exist
   settings <- papply(settings, check.inputs)
