BridgeJS: Add missing function keyword for namespace function declarations in TypeScript (swiftwasm#592)

krodak · web-flow · commit b1fb45edf79e · 2026-02-05T23:30:36.000+09:00
diff --git a/Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift b/Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift
@@ -3094,7 +3094,7 @@ extension BridgeJSLink {
                         let sortedFunctions = childNode.content.functions.sorted { $0.name < $1.name }
                         for function in sortedFunctions {
                             let signature =
-                                "\(function.name)\(renderTSSignatureCallback(function.parameters, function.returnType, function.effects));"
+                                "function \(function.name)\(renderTSSignatureCallback(function.parameters, function.returnType, function.effects));"
                             printer.write(signature)
                         }
                         let sortedProperties = childNode.content.staticProperties.sorted { $0.name < $1.name }
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.Global.d.ts b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.Global.d.ts
@@ -61,9 +61,9 @@ declare global {
     namespace Services {
         namespace Graph {
             namespace GraphOperations {
-                createGraph(rootId: number): number;
-                nodeCount(graphId: number): number;
-                validate(graphId: number): boolean;
+                function createGraph(rootId: number): number;
+                function nodeCount(graphId: number): number;
+                function validate(graphId: number): boolean;
             }
         }
     }
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedModules.d.ts b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedModules.d.ts
@@ -12,7 +12,7 @@ declare global {
             constructor();
             greet(): string;
         }
-        globalFunction(): string;
+        function globalFunction(): string;
     }
 }
 
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.Global.d.ts b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.Global.d.ts
@@ -9,7 +9,7 @@ export {};
 declare global {
     namespace MyModule {
         namespace Utils {
-            namespacedFunction(): string;
+            function namespacedFunction(): string;
         }
     }
     namespace Utils {
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.Global.d.ts b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.Global.d.ts
@@ -33,7 +33,7 @@ export {};
 declare global {
     namespace Utils {
         namespace String {
-            uppercase(text: string): string;
+            function uppercase(text: string): string;
         }
     }
 }
diff --git a/Sources/JavaScriptKit/Documentation.docc/Articles/BridgeJS/Exporting-Swift/Exporting-Swift-Static-Functions.md b/Sources/JavaScriptKit/Documentation.docc/Articles/BridgeJS/Exporting-Swift/Exporting-Swift-Static-Functions.md
@@ -140,7 +140,7 @@ Generated TypeScript definitions:
 declare global {
     namespace Utils {
         namespace String {
-            uppercase(text: string): string;
+            function uppercase(text: string): string;
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -3094,7 +3094,7 @@ extension BridgeJSLink {`
`3094`	`3094`	`let sortedFunctions = childNode.content.functions.sorted { $0.name < $1.name }`
`3095`	`3095`	`for function in sortedFunctions {`
`3096`	`3096`	`let signature =`
`3097`		`- "\(function.name)\(renderTSSignatureCallback(function.parameters, function.returnType, function.effects));"`
	`3097`	`+ "function \(function.name)\(renderTSSignatureCallback(function.parameters, function.returnType, function.effects));"`
`3098`	`3098`	`printer.write(signature)`
`3099`	`3099`	`}`
`3100`	`3100`	`let sortedProperties = childNode.content.staticProperties.sorted { $0.name < $1.name }`
Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,9 @@ declare global {`
`61`	`61`	`namespace Services {`
`62`	`62`	`namespace Graph {`
`63`	`63`	`namespace GraphOperations {`
`64`		`- createGraph(rootId: number): number;`
`65`		`- nodeCount(graphId: number): number;`
`66`		`- validate(graphId: number): boolean;`
	`64`	`+ function createGraph(rootId: number): number;`
	`65`	`+ function nodeCount(graphId: number): number;`
	`66`	`+ function validate(graphId: number): boolean;`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ declare global {`
`12`	`12`	`constructor();`
`13`	`13`	`greet(): string;`
`14`	`14`	`}`
`15`		`- globalFunction(): string;`
	`15`	`+ function globalFunction(): string;`
`16`	`16`	`}`
`17`	`17`	`}`
`18`	`18`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ export {};`
`9`	`9`	`declare global {`
`10`	`10`	`namespace MyModule {`
`11`	`11`	`namespace Utils {`
`12`		`- namespacedFunction(): string;`
	`12`	`+ function namespacedFunction(): string;`
`13`	`13`	`}`
`14`	`14`	`}`
`15`	`15`	`namespace Utils {`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ export {};`
`33`	`33`	`declare global {`
`34`	`34`	`namespace Utils {`
`35`	`35`	`namespace String {`
`36`		`- uppercase(text: string): string;`
	`36`	`+ function uppercase(text: string): string;`
`37`	`37`	`}`
`38`	`38`	`}`
`39`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ Generated TypeScript definitions:`
`140`	`140`	`declare global {`
`141`	`141`	`namespace Utils {`
`142`	`142`	`namespace String {`
`143`		`- uppercase(text: string): string;`
	`143`	`+ function uppercase(text: string): string;`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`	`}`