Enums as seperate integer types instead of aliases#4
Merged
Free-Pascal-meets-SDL-Website merged 12 commits intoPascalGameDevelopment:masterfrom Aug 1, 2021
Conversation
Collaborator
|
I do not see any problem with this PR. |
… 'master' Merge conflicts: - sdlblendmode.inc
Collaborator
|
Hey suve, is this finished? I do not see any problems with this. Regards Matthias |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset converts some of the enum types encountered in the headers from simple aliases to separate types. By utilising the
type X = type Integerfeature present in FPC, it informs the compiler that the numerical types should be considered separate and, without an explicit last, it should be impossible to assign a value from enumA to enumB.Things to consider:
SInt32as an argument / return type, where they should name a specific enum?