Skip to content

sanfilip windows curses fix#380

Merged
sanfilip merged 4 commits intomasterfrom
sanfilip-windows-curses-fix
Dec 16, 2021
Merged

sanfilip windows curses fix#380
sanfilip merged 4 commits intomasterfrom
sanfilip-windows-curses-fix

Conversation

@sanfilip
Copy link
Contributor

No description provided.

Copy link

@marquiswashere marquiswashere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sanfilip
Copy link
Contributor Author

@cwetherill-ps @lamroger the tests seem broken unrelated to my change. Also there doesn't seem to be any deveoper readme here anymore on how to build and validate this open-source repo of ours. Is there documentation elsewhere?

@cwetherill-ps
Copy link
Contributor

../gradient/api_sdk/repositories/gradient_deployments.py:1: in <module>
    from gql import gql
E   ModuleNotFoundError: No module named 'gql'

@lamroger are we missing this in the tests' dependencies somewhere?

@sanfilip
Copy link
Contributor Author

@lamroger I think I figured it out. The dist build doesn't actually detect malformed dependencies, and I missed a comma.

@sanfilip sanfilip merged commit 10b4034 into master Dec 16, 2021
@sanfilip sanfilip deleted the sanfilip-windows-curses-fix branch December 16, 2021 22:28
@PSBOT
Copy link

PSBOT commented Dec 16, 2021

🎉 This PR is included in version 1.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@PSBOT PSBOT added the released label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants