Open
Conversation
nickwinder
reviewed
Feb 2, 2026
nickwinder
left a comment
nickwinder
left a comment
There was a problem hiding this comment.
Quick pass. Worth answering my comment before I look again
| # Type definitions for file inputs | ||
| # Breaking change in v3.0.0: FileInput no longer includes URL strings | ||
| LocalFileInput = Path | bytes | BinaryIO | ||
| FileInputWithUrl = str | Path | bytes | BinaryIO |
There was a problem hiding this comment.
Should this not just be a string, i.e. just url?
Collaborator
Author
There was a problem hiding this comment.
Sorry I don't fully get the question, FileInputWithUrl is an union type between LocalFileInput and the type string. So you want me to write something like
FileInputWithUrl = str | LocalFileInput
instead?
There was a problem hiding this comment.
Arh ok. The naming of FileInputWithUrl confused me. I assumed the types were either "local file" or "url" and unioned elsewhere.
Just be more explicit with the naming and union-ing
Suggested change
| FileInputWithUrl = str | Path | bytes | BinaryIO | |
| LocalFileInput = Path | bytes | BinaryIO | |
| UrlFileInput = str | |
| FileInput = UrlFileInput | LocalFileInput |
Co-authored-by: Nick Winder <nfxdevelopment@gmail.com>
Co-authored-by: Nick Winder <nfxdevelopment@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply similar changes to PSPDFKit-labs/nutrient-dws-client-typescript#8
Cutting for release under v3.0