Merged
Conversation
jrfnl
added
Type: chores/QA
PR: quick merge
jrfnl
force-pushed
the
feature/travis-php-74-not-allowed-to-fail
branch
2 times, most recently
from
a63a4c3 to
c17936c
Compare
wimg
approved these changes
Dec 1, 2019
wimg
requested changes
Dec 1, 2019
Member
wimg
left a comment
wimg
left a comment
There was a problem hiding this comment.
Looks like Travis isn't ready for this after all ?
As [PHP 7.4 has been released](https://www.php.net/archive/2019.php#2019-11-28-1), the build against PHP 7.4 should no longer be allowed to fail. Includes some tweaking of the matrix to have the coverage stage and the quick test stage include PHP 7.4.
jrfnl
force-pushed
the
feature/travis-php-74-not-allowed-to-fail
branch
from
c17936c to
73f8953
Compare
Member
Author
Yes and no. There still isn't a |
wimg
approved these changes
Dec 2, 2019
jrfnl
removed
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As PHP 7.4 has been released, the build against PHP 7.4 should no longer be allowed to fail.
Includes some tweaking of the matrix to have the coverage stage and the quick test stage include PHP 7.4.