Merged
Conversation
Most error messages in PHPCompatibility follow one of the below formats: * "Feature x is not supported in PHP x.x and below" (new features) * "Feature x was deprecated in PHP x.x and removed in PHP x.x" (removed features) The error message for short array syntax did not follow that typical pattern and was confusing to some - I've recently had questions about it from a few different people -, so I'm proposing to adjust the error message to be more in line with other messages in the PHPCompatibility library.
jrfnl
added
Type: chores/QA
PR: quick merge
wimg
approved these changes
Nov 20, 2019
jrfnl
removed
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most error messages in PHPCompatibility follow one of the below formats:
The error message for short array syntax did not follow that typical pattern and was confusing to some - I've recently had questions about it from a few different people -, so I'm proposing to adjust the error message to be more in line with other messages in the PHPCompatibility library.