ForbiddenNames: allow for foreach( ... as list() ) {}#930
Merged
Conversation
jrfnl
added
Type: bug
PR: high priority
PR: quick merge
jrfnl
force-pushed
the
feature/928-bug-fix-forbidden-names-as-list
branch
from
a862989 to
16bccca
Compare
The changes in PR 923 did not take `foreach ( ...as list() ) {}` into account.
Fixed now. Includes unit test.
Fixes 928
Closes 929
Member
Author
|
FYI: in an attempt to find more false positives, I've done a run of this sniff against every single test case file in the PHPCompatibility repo and haven't found any others, so 🤞 |
timmillwood
approved these changes
Nov 13, 2019
Contributor
|
When will this be merged? |
Member
Author
Once @wimg has had a chance to review the PR. |
wimg
approved these changes
Nov 14, 2019
jrfnl
removed
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in PR #923 did not take
foreach ( ...as list() ) {}into account.Fixed now. Includes unit test.
Fixes #928
Closes #929