RemovedImplodeFlexibleParamOrder: fix two bugs + one enhancement#891
Merged
RemovedImplodeFlexibleParamOrder: fix two bugs + one enhancement#891
Conversation
jrfnl
added
Type: bug
Type: enhancement
PR: quick merge
wimg
reviewed
Sep 5, 2019
PHPCompatibility/Tests/ParameterValues/RemovedImplodeFlexibleParamOrderUnitTest.php
Outdated
Show resolved
Hide resolved
wimg
approved these changes
Sep 5, 2019
jrfnl
force-pushed
the
feature/890-implode-order-bug
branch
from
4ac867d to
db5e306
Compare
Bugs: 1. "Empty" tokens (whitespace, comments) were not disregarded when determining whether the first parameter was only a text string, which could lead to the second parameter being examined when it doesn't need to be. 2. If either parameter contained a ternary, potentially nested in some other construct, the ternary would confuse the sniff. Both fixed now. In addition to this if one of the parameters contains an `(array)` cast, let's presume that's the array parameter. This may lead to some false positives for complexly build parameters, but we'll deal with that later if needs be. Includes unit tests. Fixes 890
wimg
approved these changes
Sep 5, 2019
jrfnl
removed
PR: ready for review
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs:
Both fixed now.
In addition to this if one of the parameters contains an
(array)cast, let's presume that's the array parameter. This may lead to some false positives for complexly build parameters, but we'll deal with that later if needs be.Includes unit tests.
Fixes #890