Conversation
jrfnl
added
Type: enhancement
PR: quick merge
> The $version parameter of curl_version() is deprecated. If any value not > equal to the default CURLVERSION_NOW is passed, a warning is raised and the > parameter is ignored. Notes: * While the changelog and the PHP native deprecation message call the parameter `$version`, the documentation calls it `$age`, so that's the parameter name used for the error message. * Using the `CURL_VERSION_NOW` constant for the value is still fine, so the sniff takes that into account. Refs: * https://github.com/php/php-src/blob/86d751f696786bcb95c580482c9884e41ccf2406/UPGRADING#L55-L57 * https://www.php.net/manual/en/function.curl-version.php * php/php-src@357da6b
jrfnl
force-pushed
the
php-7.4/removedfunctionparams-curl-version-age
branch
from
0055206 to
decf6ec
Compare
delete-merged-branch
bot
deleted the
php-7.4/removedfunctionparams-curl-version-age
branch
jrfnl
removed
PR: ready for review
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
$version, the documentation calls it$age, so that's the parameter name used for the error message.CURL_VERSION_NOWconstant for the value is still fine, so the sniff takes that into account.Refs:
Related to #808