PHP 7.4: new NewPasswordAlgoConstantValues sniff#865
Merged
Conversation
40 tasks
jrfnl
force-pushed
the
php-7.4/new-password-hash-algo-constant-values-sniff
branch
from
dabce45 to
fc6d897
Compare
> Password hashing algorithm identifiers are now nullable strings rather > than integers. > > * PASSWORD_DEFAULT was int 1; now is null > * PASSWORD_BCRYPT was int 1; now is string '2y' > * PASSWORD_ARGON2I was int 2; now is string 'argon2i' > * PASSWORD_ARGON2ID was int 3; now is string 'argon2id' > > Applications correctly using the constants PASSWORD_DEFAULT, > PASSWORD_BCRYPT, PASSWORD_ARGON2I, and PASSWORD_ARGON2ID will continue to function correctly. Refs: * https://wiki.php.net/rfc/password_registry * https://github.com/php/php-src/blob/86d751f696786bcb95c580482c9884e41ccf2406/UPGRADING#L131-L141 * php/php-src@534df87 Includes unit tests. **Note**: while deprecated in name, it looks like the deprecation warning for use of the _constant value_ rather than the _constant_ has not been implemented. All the more reason, of course, that the sniff is necessary.
jrfnl
force-pushed
the
php-7.4/new-password-hash-algo-constant-values-sniff
branch
from
fc6d897 to
06314df
Compare
wimg
approved these changes
Aug 28, 2019
delete-merged-branch
bot
deleted the
php-7.4/new-password-hash-algo-constant-values-sniff
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
Includes unit tests.
Note: while deprecated in name, it looks like the deprecation warning for use of the constant value rather than the constant has not been implemented.
All the more reason, of course, that the sniff is necessary.
Related to #808