Skip to content

PHP 5.2/7.4: new RemovedMbStrrposEncodingThirdParam sniff#860

Merged
wimg merged 1 commit intomasterfrom
php-7.4/new-removed-mb-strrpos-encoding-as-third-param
Aug 28, 2019
Merged

PHP 5.2/7.4: new RemovedMbStrrposEncodingThirdParam sniff#860
wimg merged 1 commit intomasterfrom
php-7.4/new-removed-mb-strrpos-encoding-as-third-param

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Aug 18, 2019

The encoding parameter was moved from the third position to the fourth in PHP 5.2.0.
For backward compatibility, encoding could be specified as the third parameter, but doing
so is deprecated and will be removed in the future.

Between PHP 5.2 and PHP 7.3, this was a deprecation in documentation only.
As of PHP 7.4, a deprecation warning will be thrown if an encoding is passed as the 3rd argument.
As of PHP 8, the argument is expected to change to accept an integer only.

Refs:

Related to #808

> The encoding parameter was moved from the third position to the fourth in PHP 5.2.0.
> For backward compatibility, encoding could be specified as the third parameter, but doing
> so is deprecated and will be removed in the future.

Between PHP 5.2 and PHP 7.3, this was a deprecation in documentation only.
As of PHP 7.4, a deprecation warning will be thrown if an encoding is passed as the 3rd argument.
As of PHP 8, the argument is expected to change to accept an integer only.

Refs:
* https://wiki.php.net/rfc/deprecations_php_7_4#mb_strrpos_with_encoding_as_3rd_argument
 * php/php-src@39e756e
@wimg wimg merged commit 2c62238 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the php-7.4/new-removed-mb-strrpos-encoding-as-third-param branch August 28, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants