Conversation
40 tasks
> For historical reasons, the `implode()` function supports passing the `$glue` and `$pieces` parameters in reverse order from the documented order of arguments. This is inconsistent and makes the argument handling non-standard (for example, strict types are not respected). This also affects the alias `join()`. > > Proposal: Emit a deprecation warning when calling `implode($pieces, $glue)` or `join($pieces, $glue)`. Calling the function with just an array continues to be allowed: `implode($pieces)` does not generate a deprecation warning. The tolerance for the reverse order is expected to be removed completely in PHP 8.0. Refs: * https://wiki.php.net/rfc/deprecations_php_7_4#implode_parameter_order_mix * https://php.net/manual/en/function.implode.php * php/php-src@46b9824 The new sniff tries to be quite comprehensive and to catch as much as is reliably sniffable. Some test runs over well-known PHP projects have fine-tuned the sniff as it is now. Includes unit tests. Related to 808
jrfnl
force-pushed
the
php-7.4/deprecations/new-removedimplodeflexibleparamorder-sniff
branch
from
e40c3e7 to
2231be6
Compare
wimg
approved these changes
Jul 22, 2019
delete-merged-branch
bot
deleted the
php-7.4/deprecations/new-removedimplodeflexibleparamorder-sniff
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tolerance for the reverse order is expected to be removed completely in PHP 8.0.
Refs:
The new sniff tries to be quite comprehensive and to catch as much as is reliably sniffable.
Some test runs over well-known PHP projects have fine-tuned the sniff as it is now.
Includes unit tests.
Related to #808