Skip to content

PHP 7.4/RemovedConstants: handle deprecated magic quote related filter constant#845

Merged
wimg merged 1 commit intomasterfrom
php-7.4/deprecations/remove-constants-filter
Jul 22, 2019
Merged

PHP 7.4/RemovedConstants: handle deprecated magic quote related filter constant#845
wimg merged 1 commit intomasterfrom
php-7.4/deprecations/remove-constants-filter

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Jul 22, 2019

Magic quotes were deprecated all the way back in PHP 5.3 and later removed in PHP 5.4. The filter extension implements a sanitization filter that mimics this behavior of magic_quotes by calling addslashes() on the input in question.

In PHP 7.3 add_slashes (FILTER_SANITIZE_ADD_SLASHES) was added as a new alias for this filter, to allow us to move away from the magic_quotes terminology.

Proposed action: Emit a deprecation notice each time the FILTER_SANITIZE_MAGIC_QUOTES filter is used and advise users to use the add_slashes (FILTER_SANITIZE_ADD_SLASHES) filter instead.

This constant is to be removed in PHP 8.0.

Refs:

Related to #808

…r constant

> Magic quotes were deprecated all the way back in PHP 5.3 and later removed in PHP 5.4. The filter extension implements a sanitization filter that mimics this behavior of `magic_quotes` by calling `addslashes()` on the input in question.
>
> In PHP 7.3 `add_slashes (FILTER_SANITIZE_ADD_SLASHES)` was added as a new alias for this filter, to allow us to move away from the `magic_quotes` terminology.
>
> Proposed action: Emit a deprecation notice each time the `FILTER_SANITIZE_MAGIC_QUOTES` filter is used and advise users to use the `add_slashes (FILTER_SANITIZE_ADD_SLASHES)` filter instead.

This constant is to be removed in PHP 8.0.

Refs:
* https://wiki.php.net/rfc/deprecations_php_7_4#filter_sanitize_magic_quotes
* php/php-src#4390
* php/php-src@cd2f2cd
@jrfnl jrfnl added Type: enhancement PR: quick merge PR only contains relatively simple changes PR: ready for review labels Jul 22, 2019
@jrfnl jrfnl added this to the 9.x Next milestone Jul 22, 2019
@jrfnl jrfnl requested a review from wimg July 22, 2019 11:18
@wimg wimg merged commit 3b6a028 into master Jul 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the php-7.4/deprecations/remove-constants-filter branch July 22, 2019 21:52
@jrfnl jrfnl removed PR: ready for review PR: quick merge PR only contains relatively simple changes labels Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants