Conversation
1. Add the `MultipleStatementAlignment` sniff
The code base basically already complies with this rule, which demands that the assignment operators for blocks of variable assignments are aligned.
When an assignment is not in a block, there should be exactly one space between the variable and the assignment.
Includes fixing up the code base for the very few places where the code didn't comply yet.
2. Add the `IncludingFile` sniff
Again, the code base already complies with this rule, safe for the unit test bootstrap, in which case it is ok that the code doesn't comply.
Includes one minor consistency fix, prefixing a global constant when used with a namespace separator to indicate global namespace.
jrfnl
added
Type: chores/QA
PR: quick merge
wimg
approved these changes
Jun 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultipleStatementAlignmentsniffThe code base basically already complies with this rule, which demands that the assignment operators for blocks of variable assignments are aligned.
When an assignment is not in a block, there should be exactly one space between the variable and the assignment.
Includes fixing up the code base for the very few places where the code didn't comply yet.
IncludingFilesniffAgain, the code base already complies with this rule, safe for the unit test bootstrap, in which case it is ok that the code doesn't comply.
Includes one minor consistency fix, prefixing a global constant when used with a namespace separator to indicate global namespace.