Skip to content

PHP 5.1: new ForbiddenAbstractPrivateMethods sniff#822

Merged
wimg merged 1 commit intomasterfrom
php-5.1/forbidden-private-abstract-methods
Jun 20, 2019
Merged

PHP 5.1: new ForbiddenAbstractPrivateMethods sniff#822
wimg merged 1 commit intomasterfrom
php-5.1/forbidden-private-abstract-methods

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Jun 17, 2019

Abstract private methods were supported between PHP 5.0.0 and PHP 5.0.4, but were then disallowed on the grounds that the behaviours of private and abstract are mutually exclusive.

Ref:

Note: the tests cannot be run on PHPCS 2.3.x in combination with PHP < 5.4.

> Abstract private methods were supported between PHP 5.0.0 and PHP 5.0.4, but were then disallowed on the grounds that the behaviours of private and abstract are mutually exclusive.

Ref:
* https://www.php.net/manual/en/migration51.oop.php#migration51.oop-methods

Note: the tests cannot be run on PHPCS 2.3.x in combination with PHP < 5.4.
@jrfnl jrfnl added this to the 9.2.0 milestone Jun 17, 2019
@jrfnl jrfnl requested a review from wimg June 17, 2019 09:53
@wimg wimg merged commit 96d71ed into master Jun 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the php-5.1/forbidden-private-abstract-methods branch June 20, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants