pfpro sniff is conflicting with some custom code#812
pfpro sniff is conflicting with some custom code#812jrfnl merged 3 commits intoPHPCompatibility:masterfrom
Conversation
|
Hi @timmillwood Thanks for this PR. I'm ok with adding the The build won't pass though until the unit test on line 46 has also been fixed. Changing that function call to For the record: |
|
Thanks @jrfnl. We have whitelisted the code for now, but would be good for this false positive to be fixed. Updated the test. |
|
@timmillwood Thanks for updating the PR. I'm sorry though, I wasn't explicit enough. The actual error message is also being tested, so this means that the test data provider also needs to be updated. |
jrfnl
left a comment
There was a problem hiding this comment.
Thank you for making those updates!
We have a function in our code, for example
pfproduct_update()which is being caught by thepfprosniff. Adding the_should fix this, as it did for mysql in #7