Skip to content

PHP 7.4: new NewArrayUnpacking sniff#804

Merged
wimg merged 1 commit intomasterfrom
php-7.4/spread-operator-in-array-expression
Jun 25, 2019
Merged

PHP 7.4: new NewArrayUnpacking sniff#804
wimg merged 1 commit intomasterfrom
php-7.4/spread-operator-in-array-expression

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented May 31, 2019

As of PHP 7.4, the spread operator can also be used to expand (unpack) arrays when declaring a new array.

Refs:

NOTE: A critical look at the sniff category & sniff name are very welcome.
Ideas to improve these are welcome.

Related #808

As of PHP 7.4, the spread operator can also be used to expand (unpack) arrays when declaring a new array.

Refs:
* https://wiki.php.net/rfc/spread_operator_for_array
* php/php-src@e829d08

**NOTE**: A critical look at the sniff category & sniff name are very welcome.
Ideas to improve these are welcome.
Copy link
Member

@wimg wimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Category and sniff name seems fine to me. Nice implementation, as usual :-)

@wimg wimg merged commit 2425e5d into master Jun 25, 2019
@wimg wimg deleted the php-7.4/spread-operator-in-array-expression branch June 25, 2019 20:09
@jrfnl
Copy link
Member Author

jrfnl commented Jun 26, 2019

Thanks ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants