Merged
Conversation
jrfnl
force-pushed
the
php-7.4/typed-properties
branch
2 times, most recently
from
e69c7e1 to
eea9f2d
Compare
PHP 7.4 will be introducing support for runtime-enforced first-class property type declarations. Ref: https://wiki.php.net/rfc/typed_properties_v2 This PR introduces a new sniff to detect the use of these and report an error if PHP < 7.4 is intended to still be supported. The PHP 7.4 implementation does not allow for properties with the `void` or `callable` type. If these are detected and PHP 7.4 is supposed to be supported, an error will be thrown as well. Related: * squizlabs/PHP_CodeSniffer#2413
jrfnl
force-pushed
the
php-7.4/typed-properties
branch
from
eea9f2d to
6a98aeb
Compare
40 tasks
wimg
approved these changes
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 7.4 will be introducing support for runtime-enforced first-class property type declarations.
Refs:
This PR introduces a new sniff to detect the use of these and report an error if PHP < 7.4 is intended to still be supported.
The PHP 7.4 implementation does not allow for properties with the
voidorcallabletype.If these are detected and PHP 7.4 is supposed to be supported, an error will be thrown as well.
Related #808