Merged
Conversation
jrfnl
added
Type: chores/QA
PR: quick merge
Contributor
|
I'm sorry - I'm very nit-picky. There is a small typo in the commit message: array_change_key_change() vs. array_change_key_case() I hope this is helpful. I appreciate all the work you do on this project! |
You learn something new every day. Never came across this function before, but definitely simplifies the `Sniff::arrayKeysToLowercase()` method. Ref: https://php.net/manual/en/function.array-change-key-case.php
jrfnl
force-pushed
the
feature/simpler-lowercase-array-keys
branch
from
45dd62e to
ec077f4
Compare
Member
Author
|
@jrchamp You are completely correct. Fixed now. |
jrfnl
changed the title
wimg
approved these changes
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You learn something new every day. Never came across this function before, but definitely simplifies the
Sniff::arrayKeysToLowercase()method.Ref: https://php.net/manual/en/function.array-change-key-case.php