Modernize: use the new PHPCS 4.x Tokens class constants #2010
Merged
Conversation
These token arrays contain the same tokens, but the `Tokens::NAME_TOKENS` array is only available in PHPCS 4.x, which is why we previously couldn't use it.
... instead of the properties to reference token arrays. This also allows for some simplifications when these token arrays are used to fill the value of a class property.
Now support for PHPCS 3.x has been dropped, only the `Tokens::...` constants should be used. The use of the properties from the `Tokens` class is deprecated. This workflow job is intended to catch any accidental/force-of-habit usages of the `Tokens` properties.
jrfnl
added
Type: chores/QA
PR: quick merge
wimg
approved these changes
Nov 30, 2025
github-actions
bot
removed
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize: prefer Tokens::NAME_TOKENS over Collections::nameTokens()
These token arrays contain the same tokens, but the
Tokens::NAME_TOKENSarray is only available in PHPCS 4.x, which is why we previously couldn't use it.Modernize: use the new PHPCS 4.x Tokens class constants
... instead of the properties to reference token arrays.
This also allows for some simplifications when these token arrays are used to fill the value of a class property.
GH Actions: add automated check for usage of Tokens::$... properties
Now support for PHPCS 3.x has been dropped, only the
Tokens::...constants should be used. The use of the properties from theTokensclass is deprecated.This workflow job is intended to catch any accidental/force-of-habit usages of the
Tokensproperties.