Conversation
…iff (RFC) > . Added asymmetric visibility support for static properties. > RFC: https://wiki.php.net/rfc/static-aviz The use of asymmetric visibility keywords in general is flagged for PHP < 8.4 via the `NewKeywords` sniff (see 1809). PHP 8.5 now allows for asymmetric visibility to be used for static properties, which was explicitly excluded in the PHP 8.4 RFC. This new sniff detects code allowed since the PHP 8.5 change. Note: this does mean that code _may_ be flagged by both sniffs: * For PHP 8.4 for the use of the keywords. * For PHP 8.5 specifically for the use of the keywords with static properties. I did consider moving the "general" check from the `NewKeywords` sniff to this new sniff, but that would be a breaking change for the error code for the PHP 8.4 error without much added benefit, other than potentially preventing two notices about slightly different aspects of the same issue. Refs: * https://wiki.php.net/rfc/static-aviz * https://github.com/php/php-src/blob/34721745833b4c9e69ed22f1b17c4c1c421f7179/UPGRADING#L194-L195 * php/php-src 16486 * php/php-src@1f6fdde Related to 1849
70 tasks
wimg
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of asymmetric visibility keywords in general is flagged for PHP < 8.4 via the
NewKeywordssniff (see #1809).PHP 8.5 now allows for asymmetric visibility to be used for static properties, which was explicitly excluded in the PHP 8.4 RFC.
This new sniff detects code allowed since the PHP 8.5 change.
Note: this does mean that code may be flagged by both sniffs:
I did consider moving the "general" check from the
NewKeywordssniff to this new sniff, but that would be a breaking change for the error code for the PHP 8.4 error without much added benefit, other than potentially preventing two notices about slightly different aspects of the same issue.Refs:
Related to #1849