FunctionDeclarations/NewClosure: bug fix - allow for anon classes within closures#1928
Merged
FunctionDeclarations/NewClosure: bug fix - allow for anon classes within closures#1928
Conversation
…hin closures A PHP 7.0+ anonymous class can be declared _within_ a closure and can use `$this` and OO hierarchy keywords, like `self`. In that case, those are not being used by the closure, but by the anonymous class. Along the same lines, all other "closed" structures, like named functions, named classes etc, can be declared within a closure and for most of these, using `$this` or `self` is perfectly valid. This commit changes the sniff to take those situations into account by skipping over any closed structures nested within a closure to prevent false positives. Includes unit tests. Fixes 1481
jrfnl
added
Type: bug
PR: quick merge
wimg
approved these changes
Oct 20, 2025
github-actions
bot
removed
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PHP 7.0+ anonymous class can be declared within a closure and can use
$thisand OO hierarchy keywords, likeself. In that case, those are not being used by the closure, but by the anonymous class.Along the same lines, all other "closed" structures, like named functions, named classes etc, can be declared within a closure and for most of these, using
$thisorselfis perfectly valid.This commit changes the sniff to take those situations into account by skipping over any closed structures nested within a closure to prevent false positives.
Includes unit tests.
Fixes #1481