ReservedNames: refactor to allow for detecting more reserved names#1592
Merged
ReservedNames: refactor to allow for detecting more reserved names#1592
Conversation
This commit adjusts the `Namespaces\ReservedNames` sniff to allow it to check for multiple namespaces (not just the `PHP` top-level namespace) and adds detection of namespace declarations using the top-level name `FFI` (as introduced in PHP 7.4) to the sniff. Includes tests.
jrfnl
added
Type: enhancement
PR: quick merge
wimg
approved these changes
Aug 4, 2023
github-actions
bot
removed
PR: ready for review
PR: quick merge
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adjusts the
Namespaces\ReservedNamessniff to allow it to check for multiple namespaces (not just thePHPtop-level namespace) and adds detection of namespace declarations using the top-level nameFFI(as introduced in PHP 7.4) to the sniff.Includes tests.
Related to #808