Conversation
… keywords are case in-sensitive See: https://3v4l.org/DgnOC Tested by adjusting some of the existing unit tests.
… PHP 7.4+ arrow functions The sniff already handles this correctly, no changes needed.
… PHP 8.1+ enums The sniff already handles this correctly, no changes needed.
jrfnl
added
Type: bug
Type: chores/QA
PR: quick merge
wimg
approved these changes
May 20, 2023
github-actions
bot
removed
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FunctionDeclarations/RemovedReturnByReferenceFromVoid: rework a test to data provider
FunctionDeclarations/RemovedReturnByReferenceFromVoid: bug fix - type keywords are case in-sensitive
See: https://3v4l.org/DgnOC
Tested by adjusting some of the existing unit tests.
FunctionDeclarations/RemovedReturnByReferenceFromVoid: add tests with PHP 7.4+ arrow functions
The sniff already handles this correctly, no changes needed.
FunctionDeclarations/RemovedReturnByReferenceFromVoid: add tests with PHP 8.1+ enums
The sniff already handles this correctly, no changes needed.