Merged
Conversation
PHP 8.0 introduces named function call parameters: ```php array_fill(start_index: 0, count: 100, value: 50); // Using reserved keywords as names is allowed. array_foobar(array: $array, switch: $switch, class: $class); ``` Ref: https://wiki.php.net/rfc/named_params This new sniff will detect the use of named parameters based on the support for this in PHPCSUtils as added in PHPCSStandards/PHPCSUtils 235 and PHPCSStandards/PHPCSUtils 383. Includes unit tests. **Open question**: should this sniff live in the `FunctionUse` category or in the `Syntax` category ?
40 tasks
wimg
approved these changes
Dec 5, 2022
Member
wimg
left a comment
wimg
left a comment
There was a problem hiding this comment.
What a super list of test cases :-D
Member
Author
|
Argh... just now thinking the sniff can be much simpler... I wrote this before we dropped support for PHPCS < 3.7.1, so that meant that for the majority of PHPCS versions supported, we'd need to work out whether something contained a parameter name ourselves (by using the PHPCSUtils functionality). Parameter names are supported in PHPCS since PHPCS 3.6.0 and are retokenized to ta separate token I'll put it on my todo list to check if we can just sniff for |
jrfnl
changed the title
NewNamedParametersSniff sniffNewNamedParameters sniff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.0 introduces named function call parameters:
Ref: https://wiki.php.net/rfc/named_params
This new sniff will detect the use of named parameters based on the support for this in PHPCSUtils as added in PHPCSStandards/PHPCSUtils#235 and PHPCSStandards/PHPCSUtils#383.
Includes unit tests.
Related to #809
Open question: should this sniff live in the
FunctionUsecategory or in theSyntaxcategory ?