Conversation
jrfnl
added
Type: enhancement
PR: quick merge
41 tasks
wimg
approved these changes
Oct 27, 2022
1. Add support for function calls using named parameters by implementing the new PHPCSUtils 1.0.0-alpha4 `PassedParameters::getParameterFromStack()` method.
2. Verified the parameter names used are in line with the names as per the PHP 8.0 release.
PHP itself renamed a lot of parameters in PHP 8.0. As named parameters did not exist before PHP 8.0, the parameter name as per PHP 8.0 (or above) is the only relevant name.
Name verification references:
* `ob_implicit_flush`: https://3v4l.org/SVXD2
* `sem_get`: https://github.com/php/php-src/blob/5aaffc8095eeb69407855b33d1939dd5ebd619ca/ext/sysvsem/sysvsem.stub.php#L9
Includes adding/adjusting the unit tests to include tests using named parameters.
Note: this is changes the error code for the `ob_implicit_flush` violation, but as this is a new sniff which is being introduced in PHPCompatibility 10.0.0, this is not an issue.
jrfnl
force-pushed
the
feature/1239-changedinttoboolparamtype-support-named-params
branch
from
3700875 to
268e153
Compare
Member
Author
|
Rebased without changes to get it passed the merged conflicts. Will merge once the build passes. |
jrfnl
deleted the
feature/1239-changedinttoboolparamtype-support-named-params
branch
jrfnl
removed
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PassedParameters::getParameterFromStack()method.Name verification references:
ob_implicit_flush: https://3v4l.org/SVXD2sem_get: https://github.com/php/php-src/blob/5aaffc8095eeb69407855b33d1939dd5ebd619ca/ext/sysvsem/sysvsem.stub.php#L9Includes adding/adjusting the unit tests to include tests using named parameters.
Note: this is changes the error code for the
ob_implicit_flushviolation, but as this is a new sniff which is being introduced in PHPCompatibility 10.0.0, this is not an issue.Related to #1239