Conversation
jrfnl
added
Type: enhancement
PR: quick merge
Member
Author
|
@afilina Want to have a look over the docs I've included ? I'm trying to add them now to any and all new sniffs I'm introducing. |
…ngNoArgs` sniff > Calling mb_check_encoding() without any arguments is deprecated. New sniff to detect this deprecation. Includes unit tests. Includes docs. Refs: * https://wiki.php.net/rfc/deprecations_php_8_1#mb_check_encoding_without_argument * https://www.php.net/manual/en/migration81.deprecated.php#migration81.deprecated.mbstring * https://www.php.net/manual/en/function.mb-check-encoding.php * php/php-src@6390158
jrfnl
force-pushed
the
php-8.1/new-removedmbcheckencodingnoargs-sniff
branch
from
d58b876 to
58f3adf
Compare
47 tasks
wimg
approved these changes
Mar 9, 2022
Contributor
|
@jrfnl I only saw it today. I recommend to remove the |
Member
Author
|
@afilina Thanks for looking these over. Regarding the |
jrfnl
removed
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New sniff to detect this deprecation.
Includes unit tests.
Includes docs.
Refs:
Related to #1299