[xml doc] RemovedPCREModifiers#1295
[xml doc] RemovedPCREModifiers#1295jrfnl merged 4 commits intoPHPCompatibility:developfrom afilina:removed-pcre-mods
Conversation
|
@jrfnl I rebased the code onto the recent |
Yes! The linting fixes have been merged over the weekend and released, so the PHP 8.1 lint is now passing 🎉 As for the tests failing on PHP 8.1 - PHPCS itself still needs to be updated for the tokenizer changes in PHP 8.1 (and also still needs to merge some other PHP 8.1 related PRs), so this is as expected and outside our control. |
|
@jrfnl Those issues are already fixed and pending PR merges on PHP_CodeSniffer.
Once those PRs are merged upstream, the CI here should turn green. |
* Add proper XML header.
Note: this is something which only recently became an option as there previously was no schema available.
* Style: have `CDATA` tags on their own lines.
This makes the XML code style consistent with currently existing XML docs.
* Expand the issue description a little.
* Use `Cross-version compatible` and `PHP </> #.#` style prefixes in the code samples.
This improves consistency with the other XML docs and makes the code samples more descriptive in the context of PHPCompatibility.
* Add `<em>` tags to the code samples to allow for highlighting the specific issue the sniff is looking for.
|
Rebased the PR and updated the document (with permission from @afilina). Will merge this one once the build passes. |
2 participants
I messed up a rebase due to inattention. This replaces #1272.
Related to #1285