Conversation
This sniff can throw an error or a warning depending on whether a `destruct()` method has been found in the class (error) or not, but the class has a parent class or uses traits (warning). This improves the message shown for the `warning` case to make it clearer how to take action on the issue. It also ensure that the error and the warning each have a unique error code.
jrfnl
added
Type: enhancement
Type: chores/QA
PR: quick merge
wimg
approved these changes
Apr 17, 2021
wimg
deleted the
php-8.0/removeddestructafterconstructorexit-improve-error-msg
branch
jrfnl
removed
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sniff can throw an error or a warning depending on whether a
destruct()method has been found in the class (error) or not, but the class has a parent class or uses traits (warning).This improves the message shown for the
warningcase to make it clearer how to take action on the issue.It also ensures that the error and the warning each have a unique error code.
Note: as this is a new sniff in PHPCompatibility 10.0.0, the error code change has no consequences.