fix(ci): pin release workflow actions to immutable SHAs#1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@v3,@v6,@release/v1) which enables supply-chain tampering if upstream tags are re-targeted or a third-party repo is compromised..github/workflows/python-publish.ymlwere relying on those mutable tags, exposing secrets and publishing privileges.Description
uses: <owner>/<action>@<tag>references in.github/workflows/python-publish.ymlwith immutable commit SHAs and left the original tag as a comment for traceability.actions/checkout,actions/upload-artifact,actions/download-artifact,actions/cache,docker/metadata-action,docker/login-action,docker/setup-buildx-action, anddocker/build-push-actionto specific SHAs.Testing
git diff --checkto ensure there are no whitespace or diff errors and it succeeded.rg "uses:\s+[^#\n]+@(v|release/)" -n .github/workflows/python-publish.ymland confirmed there are no matches.git status --shortwhich reported the updated.github/workflows/python-publish.yml.Codex Task