Skip to content

fix(sqlite): preserve view metadata identity - #2837

Open
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/sqlite-view-metadata
Open

fix(sqlite): preserve view metadata identity#2837
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/sqlite-view-metadata

Conversation

@HandSonic

@HandSonic HandSonic commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Related issue

N/A - no matching issue was found.

Summary

SQLite view detail metadata populated the DDL but omitted the requested view name and schema. Downstream consumers received an anonymous view even when the definition query succeeded. This change preserves database, schema, and name before querying the definition and leaves the DDL unchanged.

Affected surfaces

  • Frontend / Web
  • Backend / API / Storage
  • Database plugin / Driver
  • JCEF / Desktop packaging
  • CI / Build / Release
  • Documentation only

Verification

  • Commands and results:
    • Red test returned null name/schema for a definition row.
    • Focused SQLite view metadata test: 1 passed.
    • SQLite module tests after rebase: 27 passed.
    • Plugin reactor package: succeeded.
    • Fork code and CodeQL checks: rerunning for the rebased head.
  • Manual verification: N/A - a strict JDBC proxy verifies requested identity plus unchanged definition.
  • UI evidence: N/A

Risk and compatibility

  • Public API or stored data: No API or stored data changes.
  • Database or driver compatibility: SQLite view detail metadata only.
  • Network, privacy, or security: N/A.
  • Community / Local / Pro boundary: Shared Community SQLite plugin.
  • Backward compatibility: Existing database/DDL fields remain unchanged; missing identity fields are now populated.

Reviewer map

  • Start here: SqliteMetaData.view and SqliteViewMetadataTest.
  • Failure condition: requested identity is missing or the returned DDL changes.
  • Rollback or disable path: Revert commit 722a3f1aff3840964528e88ef9cb93bec133abdc; no migration is required.

Contributor declaration

  • I linked the Issue that defines this change.
  • I tested the affected behavior and reported the actual results above.
  • I did not include credentials, private data, or generated build output.
  • I disclosed substantial AI assistance below, or this PR contains no substantial AI-generated code.

AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, and adversarial review.

@HandSonic
HandSonic force-pushed the fix/sqlite-view-metadata branch from 36d5c0b to 722a3f1 Compare September 3, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants