Skip to content

Commit d2a9fde

Browse files
anson627anson627
committed
Rename to float16.Num
1 parent df2645c commit d2a9fde

5 files changed

Lines changed: 20 additions & 20 deletions

File tree

‎go/arrow/array/float16.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import (
2727
// A type which represents an immutable sequence of Float16 values.
2828
type Float16 struct {
2929
array
30-
values []float16.Float16
30+
values []float16.Num
3131
}
3232

3333
func NewFloat16Data(data *Data) *Float16 {
@@ -37,9 +37,9 @@ func NewFloat16Data(data *Data) *Float16 {
3737
return a
3838
}
3939

40-
func (a *Float16) Value(i int) float16.Float16 { return a.values[i] }
40+
func (a *Float16) Value(i int) float16.Num { return a.values[i] }
4141

42-
func (a *Float16) Values() []float16.Float16 { return a.values }
42+
func (a *Float16) Values() []float16.Num { return a.values }
4343

4444
func (a *Float16) String() string {
4545
o := new(strings.Builder)

‎go/arrow/array/float16_builder.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ type Float16Builder struct {
3030
builder
3131

3232
data *memory.Buffer
33-
rawData []float16.Float16
33+
rawData []float16.Num
3434
}
3535

3636
func NewFloat16Builder(mem memory.Allocator) *Float16Builder {
@@ -55,12 +55,12 @@ func (b *Float16Builder) Release() {
5555
}
5656
}
5757

58-
func (b *Float16Builder) Append(v float16.Float16) {
58+
func (b *Float16Builder) Append(v float16.Num) {
5959
b.Reserve(1)
6060
b.UnsafeAppend(v)
6161
}
6262

63-
func (b *Float16Builder) UnsafeAppend(v float16.Float16) {
63+
func (b *Float16Builder) UnsafeAppend(v float16.Num) {
6464
bitutil.SetBit(b.nullBitmap.Bytes(), b.length)
6565
b.rawData[b.length] = v
6666
b.length++
@@ -83,7 +83,7 @@ func (b *Float16Builder) UnsafeAppendBoolToBitmap(isValid bool) {
8383
// AppendValues will append the values in the v slice. The valid slice determines which values
8484
// in v are valid (not null). The valid slice must either be empty or be equal in length to v. If empty,
8585
// all values in v are appended and considered valid.
86-
func (b *Float16Builder) AppendValues(v []float16.Float16, valid []bool) {
86+
func (b *Float16Builder) AppendValues(v []float16.Num, valid []bool) {
8787
if len(v) != len(valid) && len(valid) != 0 {
8888
panic("len(v) != len(valid) && len(valid) != 0")
8989
}

‎go/arrow/array/float16_builder_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ func TestFloat16Builder_Empty(t *testing.T) {
8888
ab := array.NewFloat16Builder(mem)
8989
defer ab.Release()
9090

91-
want := []float16.Float16{float16.NewFloat16(3), float16.NewFloat16(4)}
91+
want := []float16.Num{float16.NewFloat16(3), float16.NewFloat16(4)}
9292

93-
ab.AppendValues([]float16.Float16{}, nil)
93+
ab.AppendValues([]float16.Num{}, nil)
9494
a := ab.NewFloat16Array()
9595
assert.Zero(t, a.Len())
9696
a.Release()
@@ -105,14 +105,14 @@ func TestFloat16Builder_Empty(t *testing.T) {
105105
assert.Equal(t, want, a.Values())
106106
a.Release()
107107

108-
ab.AppendValues([]float16.Float16{}, nil)
108+
ab.AppendValues([]float16.Num{}, nil)
109109
ab.AppendValues(want, nil)
110110
a = ab.NewFloat16Array()
111111
assert.Equal(t, want, a.Values())
112112
a.Release()
113113

114114
ab.AppendValues(want, nil)
115-
ab.AppendValues([]float16.Float16{}, nil)
115+
ab.AppendValues([]float16.Num{}, nil)
116116
a = ab.NewFloat16Array()
117117
assert.Equal(t, want, a.Values())
118118
a.Release()

‎go/arrow/float16/float16.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ import (
2020
"math"
2121
)
2222

23-
type Float16 uint16
23+
type Num uint16
2424

2525
// https://en.wikipedia.org/wiki/Half-precision_floating-point_format
26-
func NewFloat16(f float32) Float16 {
26+
func NewFloat16(f float32) Num {
2727
b := math.Float32bits(f)
2828
sn := uint16((b >> 31) & 0x1)
2929
exp := (b >> 23) & 0xff
@@ -41,10 +41,10 @@ func NewFloat16(f float32) Float16 {
4141
res = 0
4242
fc = 0
4343
}
44-
return Float16((sn << 15) | uint16(res<<10) | fc)
44+
return Num((sn << 15) | uint16(res<<10) | fc)
4545
}
4646

47-
func (f Float16) Float32() float32 {
47+
func (f Num) Float32() float32 {
4848
sn := uint32((f >> 15) & 0x1)
4949
exp := (f >> 10) & 0x1f
5050
res := uint32(exp) + 127 - 15

‎go/arrow/type_traits_float16.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,17 @@ type float16Traits struct{}
3838
func (float16Traits) BytesRequired(n int) int { return Float16SizeBytes * n }
3939

4040
// PutValue
41-
func (float16Traits) PutValue(b []byte, v float16.Float16) {
41+
func (float16Traits) PutValue(b []byte, v float16.Num) {
4242
binary.LittleEndian.PutUint16(b, uint16(v))
4343
}
4444

4545
// CastFromBytes reinterprets the slice b to a slice of type uint16.
4646
//
4747
// NOTE: len(b) must be a multiple of Uint16SizeBytes.
48-
func (float16Traits) CastFromBytes(b []byte) []float16.Float16 {
48+
func (float16Traits) CastFromBytes(b []byte) []float16.Num {
4949
h := (*reflect.SliceHeader)(unsafe.Pointer(&b))
5050

51-
var res []float16.Float16
51+
var res []float16.Num
5252
s := (*reflect.SliceHeader)(unsafe.Pointer(&res))
5353
s.Data = h.Data
5454
s.Len = h.Len / Float16SizeBytes
@@ -58,7 +58,7 @@ func (float16Traits) CastFromBytes(b []byte) []float16.Float16 {
5858
}
5959

6060
// CastToBytes reinterprets the slice b to a slice of bytes.
61-
func (float16Traits) CastToBytes(b []float16.Float16) []byte {
61+
func (float16Traits) CastToBytes(b []float16.Num) []byte {
6262
h := (*reflect.SliceHeader)(unsafe.Pointer(&b))
6363

6464
var res []byte
@@ -71,4 +71,4 @@ func (float16Traits) CastToBytes(b []float16.Float16) []byte {
7171
}
7272

7373
// Copy copies src to dst.
74-
func (float16Traits) Copy(dst, src []float16.Float16) { copy(dst, src) }
74+
func (float16Traits) Copy(dst, src []float16.Num) { copy(dst, src) }

0 commit comments

Comments
 (0)