Skip to content

Commit b970168

Browse files
committed
Rename NewFloat16 to New
1 parent 4e7a837 commit b970168

3 files changed

Lines changed: 13 additions & 13 deletions

File tree

go/arrow/array/float16_builder_test.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,16 @@ func TestNewFloat16Builder(t *testing.T) {
3939

4040
ab := array.NewFloat16Builder(mem)
4141

42-
ab.Append(float16.NewFloat16(1))
43-
ab.Append(float16.NewFloat16(2))
44-
ab.Append(float16.NewFloat16(3))
42+
ab.Append(float16.New(1))
43+
ab.Append(float16.New(2))
44+
ab.Append(float16.New(3))
4545
ab.AppendNull()
46-
ab.Append(float16.NewFloat16(5))
47-
ab.Append(float16.NewFloat16(6))
46+
ab.Append(float16.New(5))
47+
ab.Append(float16.New(6))
4848
ab.AppendNull()
49-
ab.Append(float16.NewFloat16(8))
50-
ab.Append(float16.NewFloat16(9))
51-
ab.Append(float16.NewFloat16(10))
49+
ab.Append(float16.New(8))
50+
ab.Append(float16.New(9))
51+
ab.Append(float16.New(10))
5252

5353
// check state of builder before NewFloat16Array
5454
assert.Equal(t, 10, ab.Len(), "unexpected Len()")
@@ -69,8 +69,8 @@ func TestNewFloat16Builder(t *testing.T) {
6969
assert.Len(t, a.Values(), 10, "unexpected length of Float16Values")
7070

7171
a.Release()
72-
ab.Append(float16.NewFloat16(7))
73-
ab.Append(float16.NewFloat16(8))
72+
ab.Append(float16.New(7))
73+
ab.Append(float16.New(8))
7474

7575
a = ab.NewFloat16Array()
7676

@@ -88,7 +88,7 @@ func TestFloat16Builder_Empty(t *testing.T) {
8888
ab := array.NewFloat16Builder(mem)
8989
defer ab.Release()
9090

91-
want := []float16.Num{float16.NewFloat16(3), float16.NewFloat16(4)}
91+
want := []float16.Num{float16.New(3), float16.New(4)}
9292

9393
ab.AppendValues([]float16.Num{}, nil)
9494
a := ab.NewFloat16Array()

go/arrow/float16/float16.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
type Num uint16
2424

2525
// https://en.wikipedia.org/wiki/Half-precision_floating-point_format
26-
func NewFloat16(f float32) Num {
26+
func New(f float32) Num {
2727
b := math.Float32bits(f)
2828
sn := uint16((b >> 31) & 0x1)
2929
exp := (b >> 23) & 0xff

go/arrow/float16/float16_test.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)