fix validation order

kszucs · kszucs · commit b7c71e040a82 · 2018-07-12T22:08:54.000+02:00
diff --git a/dev/tasks/crossbow.py b/dev/tasks/crossbow.py
@@ -387,19 +387,18 @@ def load_tasks_from_config(config_path, task_names, group_names):
     with Path(config_path).open() as fp:
         config = yaml.load(fp)
 
-    valid_tasks = set(config['tasks'].keys())
     valid_groups = set(config['groups'].keys())
-
     requested_groups = set(group_names)
-    requested_tasks = set(
-        sum([config['groups'][g] for g in group_names], list(task_names))
-    )
     invalid_groups = requested_groups - valid_groups
-    invalid_tasks = requested_tasks - valid_tasks
-
     if invalid_groups:
         raise click.ClickException('Invalid group(s) {!r}. Must be one of {!r}'
                                    .format(invalid_groups, valid_groups))
+
+    valid_tasks = set(config['tasks'].keys())
+    requested_tasks = set(
+        sum([config['groups'][g] for g in group_names], list(task_names))
+    )
+    invalid_tasks = requested_tasks - valid_tasks
     if invalid_tasks:
         raise click.ClickException('Invalid task(s) {!r}. Must be one of {!r}'
                                    .format(invalid_tasks, valid_tasks))
