ARROW-12756: [C++] MSVC build fails with latest gtest from vcpkg

ianmcook · kszucs · commit b2cd20067c08 · 2021-05-13T14:16:36.000+02:00
This pins gtest to version 1.10.0 in the vcpkg manifest Closes apache#10306 from ianmcook/ARROW-12756 Authored-by: Ian Cook <ianmcook@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
diff --git a/cpp/vcpkg.json b/cpp/vcpkg.json
@@ -36,5 +36,9 @@
     "utf8proc",
     "zlib",
     "zstd"
-  ]
+  ],
+  "overrides": [
+    { "name": "gtest", "version": "1.10.0", "port-version": 4 }
+  ],
+  "builtin-baseline": "a267ab118c09f56f3dae96c9a4b3410820ad2f0b"
 }
diff --git a/dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat b/dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat
@@ -29,6 +29,7 @@ call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Too
 vcpkg install ^
     --triplet x64-windows ^
     --x-manifest-root cpp  ^
+    --feature-flags=versions ^
     --clean-after-build ^
     || exit /B 1
 
diff --git a/docs/source/developers/cpp/building.rst b/docs/source/developers/cpp/building.rst
@@ -77,6 +77,7 @@ With `vcpkg <https://github.com/Microsoft/vcpkg>`_:
    cd arrow
    vcpkg install \
      --x-manifest-root cpp \
+     --feature-flags=versions \
      --clean-after-build
 
 On MSYS2:
@@ -294,7 +295,7 @@ the build system how to resolve each dependency. There are a few options:
   have this feature
 * ``CONDA``: Use ``$CONDA_PREFIX`` as alternative ``SYSTEM`` PATH
 * ``VCPKG``: Find dependencies installed by vcpkg, and if not found, run
-  ``vpckg install`` to install them
+  ``vcpkg install`` to install them
 * ``BREW``: Use Homebrew default paths as an alternative ``SYSTEM`` path
 
 The default method is ``AUTO`` unless you are developing within an active conda
diff --git a/docs/source/developers/cpp/windows.rst b/docs/source/developers/cpp/windows.rst
@@ -134,6 +134,7 @@ of Arrow and run the command:
    vcpkg install ^
      --triplet x64-windows ^
      --x-manifest-root cpp  ^
+     --feature-flags=versions ^
      --clean-after-build
 
 On Windows, vcpkg builds dynamic link libraries by default. Use the triplet
