assign should compare column names, not fields

trxcllnt · trxcllnt · commit 4898fbdffa53 · 2019-02-26T20:17:18.000-08:00
diff --git a/js/src/schema.ts b/js/src/schema.ts
@@ -92,8 +92,8 @@ export class Schema<T extends { [key: string]: DataType } = any> {
         const curDictionaryFields = this.dictionaryFields;
         const metadata = mergeMaps(mergeMaps(new Map(), this.metadata), other.metadata);
         const newFields = other.fields.filter((f2) => {
-            const i = curFields.findIndex((f) => f.compareTo(f2));
-            return ~i ? (curFields[i] = curFields[i].clone({
+            const i = curFields.findIndex((f) => f.name === f2.name);
+            return ~i ? (curFields[i] = f2.clone({
                 metadata: mergeMaps(mergeMaps(new Map(), curFields[i].metadata), f2.metadata)
             })) && false : true;
         }) as Field[];
@@ -102,7 +102,7 @@ export class Schema<T extends { [key: string]: DataType } = any> {
         const newDictionaries = [...dictionaries].filter(([y]) => !curDictionaries.every(([x]) => x === y));
         const newDictionaryFields = [...dictionaryFields].map(([id, newDictFields]) => {
             return [id, [...(curDictionaryFields.get(id) || []), ...newDictFields.map((f) => {
-                const i = newFields.findIndex((f2) => f2.compareTo(f));
+                const i = newFields.findIndex((f2) => f.name === f2.name);
                 const { dictionary, indices, isOrdered, dictionaryVector } = f.type;
                 const type = new Dictionary(dictionary, indices, id, isOrdered, dictionaryVector);
                 return newFields[i] = f.clone({ type });
diff --git a/js/src/table.ts b/js/src/table.ts
@@ -254,7 +254,7 @@ export class Table<T extends { [key: string]: DataType } = any>
         const fields = this._schema.fields;
         const [indices, oldToNew] = other.schema.fields.reduce((memo, f2, newIdx) => {
             const [indices, oldToNew] = memo;
-            const i = fields.findIndex((f) => f.compareTo(f2));
+            const i = fields.findIndex((f) => f.name === f2.name);
             ~i ? (oldToNew[i] = newIdx) : indices.push(newIdx);
             return memo;
         }, [[], []] as number[][]);
