Uses less verbose syntax for object creation

paddyhoran · paddyhoran · commit 2caeb65a0b0b · 2018-08-19T22:27:21.000-04:00
diff --git a/rust/src/array.rs b/rust/src/array.rs
@@ -106,7 +106,7 @@ struct RawPtrBox<T> {
 
 impl<T> RawPtrBox<T> {
     fn new(inner: *const T) -> Self {
-        Self { inner: inner }
+        Self { inner }
     }
 
     fn get(&self) -> *const T {
@@ -244,7 +244,7 @@ impl<T: ArrowPrimitiveType> From<ArrayDataRef> for PrimitiveArray<T> {
         let raw_values = data.buffers()[0].raw_data();
         assert!(memory::is_aligned::<u8>(raw_values, mem::align_of::<T>()));
         Self {
-            data: data,
+            data,
             raw_values: RawPtrBox::new(raw_values as *const T),
         }
     }
@@ -336,7 +336,7 @@ impl From<ArrayDataRef> for ListArray {
         }
         Self {
             data: data.clone(),
-            values: values,
+            values,
             value_offsets: RawPtrBox::new(value_offsets),
         }
     }
@@ -479,8 +479,8 @@ impl From<ArrayDataRef> for StructArray {
             boxed_fields.push(make_array(cd.clone()));
         }
         Self {
-            data: data,
-            boxed_fields: boxed_fields,
+            data,
+            boxed_fields,
         }
     }
 }
diff --git a/rust/src/array_data.rs b/rust/src/array_data.rs
@@ -156,7 +156,7 @@ pub struct ArrayDataBuilder {
 impl ArrayDataBuilder {
     pub fn new(data_type: DataType) -> Self {
         Self {
-            data_type: data_type,
+            data_type,
             len: 0,
             null_count: UNKNOWN_NULL_COUNT,
             null_bit_buffer: None,
diff --git a/rust/src/buffer.rs b/rust/src/buffer.rs
@@ -60,7 +60,7 @@ impl Buffer {
     /// Creates a buffer from an existing memory region (must already be byte-aligned)
     pub fn from_raw_parts(ptr: *const u8, len: usize) -> Self {
         assert!(memory::is_aligned(ptr, 64));
-        let buf_data = BufferData { ptr: ptr, len: len };
+        let buf_data = BufferData { ptr, len };
         Buffer {
             data: Arc::new(buf_data),
             offset: 0,
diff --git a/rust/src/datatypes.rs b/rust/src/datatypes.rs
@@ -193,8 +193,8 @@ impl Field {
     pub fn new(name: &str, data_type: DataType, nullable: bool) -> Self {
         Field {
             name: name.to_string(),
-            data_type: data_type,
-            nullable: nullable,
+            data_type,
+            nullable,
         }
     }
 
@@ -284,7 +284,7 @@ impl Schema {
     }
 
     pub fn new(columns: Vec<Field>) -> Self {
-        Schema { columns: columns }
+        Schema { columns }
     }
 
     pub fn columns(&self) -> &Vec<Field> {

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ struct RawPtrBox<T> {`
`106`	`106`
`107`	`107`	`impl<T> RawPtrBox<T> {`
`108`	`108`	`fn new(inner: *const T) -> Self {`
`109`		`- Self { inner: inner }`
	`109`	`+ Self { inner }`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`fn get(&self) -> *const T {`
`@@ -244,7 +244,7 @@ impl<T: ArrowPrimitiveType> From<ArrayDataRef> for PrimitiveArray<T> {`
`244`	`244`	`let raw_values = data.buffers()[0].raw_data();`
`245`	`245`	`assert!(memory::is_aligned::<u8>(raw_values, mem::align_of::<T>()));`
`246`	`246`	`Self {`
`247`		`- data: data,`
	`247`	`+ data,`
`248`	`248`	`raw_values: RawPtrBox::new(raw_values as *const T),`
`249`	`249`	`}`
`250`	`250`	`}`
`@@ -336,7 +336,7 @@ impl From<ArrayDataRef> for ListArray {`
`336`	`336`	`}`
`337`	`337`	`Self {`
`338`	`338`	`data: data.clone(),`
`339`		`- values: values,`
	`339`	`+ values,`
`340`	`340`	`value_offsets: RawPtrBox::new(value_offsets),`
`341`	`341`	`}`
`342`	`342`	`}`
`@@ -479,8 +479,8 @@ impl From<ArrayDataRef> for StructArray {`
`479`	`479`	`boxed_fields.push(make_array(cd.clone()));`
`480`	`480`	`}`
`481`	`481`	`Self {`
`482`		`- data: data,`
`483`		`- boxed_fields: boxed_fields,`
	`482`	`+ data,`
	`483`	`+ boxed_fields,`
`484`	`484`	`}`
`485`	`485`	`}`
`486`	`486`	`}`
Original file line number	Diff line number	Diff line change
`@@ -193,8 +193,8 @@ impl Field {`
`193`	`193`	`pub fn new(name: &str, data_type: DataType, nullable: bool) -> Self {`
`194`	`194`	`Field {`
`195`	`195`	`name: name.to_string(),`
`196`		`- data_type: data_type,`
`197`		`- nullable: nullable,`
	`196`	`+ data_type,`
	`197`	`+ nullable,`
`198`	`198`	`}`
`199`	`199`	`}`
`200`	`200`
`@@ -284,7 +284,7 @@ impl Schema {`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`pub fn new(columns: Vec<Field>) -> Self {`
`287`		`- Schema { columns: columns }`
	`287`	`+ Schema { columns }`
`288`	`288`	`}`
`289`	`289`
`290`	`290`	`pub fn columns(&self) -> &Vec<Field> {`