forked from apache/arrow
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathcolumn_reader_test.cc
More file actions
1215 lines (1083 loc) · 47.6 KB
/
Copy pathcolumn_reader_test.cc
File metadata and controls
1215 lines (1083 loc) · 47.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
#include <gmock/gmock.h>
#include <gtest/gtest.h>
#include <algorithm>
#include <cstdint>
#include <cstdlib>
#include <limits>
#include <memory>
#include <string>
#include <utility>
#include <vector>
#include "arrow/array/array_binary.h"
#include "arrow/util/macros.h"
#include "parquet/column_page.h"
#include "parquet/column_reader.h"
#include "parquet/schema.h"
#include "parquet/test_util.h"
#include "parquet/types.h"
namespace parquet {
using parquet::Repetition;
using parquet::internal::BinaryRecordReader;
using schema::NodePtr;
using testing::ElementsAre;
namespace test {
template <typename T>
static inline bool vector_equal_with_def_levels(const std::vector<T>& left,
const std::vector<int16_t>& def_levels,
int16_t max_def_levels,
int16_t max_rep_levels,
const std::vector<T>& right) {
size_t i_left = 0;
size_t i_right = 0;
for (size_t i = 0; i < def_levels.size(); i++) {
if (def_levels[i] == max_def_levels) {
// Compare
if (left[i_left] != right[i_right]) {
std::cerr << "index " << i << " left was " << left[i_left] << " right was "
<< right[i] << std::endl;
return false;
}
i_left++;
i_right++;
} else if (def_levels[i] == (max_def_levels - 1)) {
// Null entry on the lowest nested level
i_right++;
} else if (def_levels[i] < (max_def_levels - 1)) {
// Null entry on a higher nesting level, only supported for non-repeating data
if (max_rep_levels == 0) {
i_right++;
}
}
}
return true;
}
class TestPrimitiveReader : public ::testing::Test {
public:
void InitReader(const ColumnDescriptor* d) {
auto pager = std::make_unique<MockPageReader>(pages_);
reader_ = ColumnReader::Make(d, std::move(pager));
}
void CheckResults() {
std::vector<int32_t> vresult(num_values_, -1);
std::vector<int16_t> dresult(num_levels_, -1);
std::vector<int16_t> rresult(num_levels_, -1);
int64_t values_read = 0;
int total_values_read = 0;
int batch_actual = 0;
Int32Reader* reader = static_cast<Int32Reader*>(reader_.get());
int32_t batch_size = 8;
int batch = 0;
// This will cover both the cases
// 1) batch_size < page_size (multiple ReadBatch from a single page)
// 2) batch_size > page_size (BatchRead limits to a single page)
do {
batch = static_cast<int>(reader->ReadBatch(
batch_size, &dresult[0] + batch_actual, &rresult[0] + batch_actual,
&vresult[0] + total_values_read, &values_read));
total_values_read += static_cast<int>(values_read);
batch_actual += batch;
batch_size = std::min(1 << 24, std::max(batch_size * 2, 4096));
} while (batch > 0);
ASSERT_EQ(num_levels_, batch_actual);
ASSERT_EQ(num_values_, total_values_read);
ASSERT_TRUE(vector_equal(values_, vresult));
if (max_def_level_ > 0) {
ASSERT_TRUE(vector_equal(def_levels_, dresult));
}
if (max_rep_level_ > 0) {
ASSERT_TRUE(vector_equal(rep_levels_, rresult));
}
// catch improper writes at EOS
batch_actual =
static_cast<int>(reader->ReadBatch(5, nullptr, nullptr, nullptr, &values_read));
ASSERT_EQ(0, batch_actual);
ASSERT_EQ(0, values_read);
}
void CheckResultsSpaced() {
std::vector<int32_t> vresult(num_levels_, -1);
std::vector<int16_t> dresult(num_levels_, -1);
std::vector<int16_t> rresult(num_levels_, -1);
std::vector<uint8_t> valid_bits(num_levels_, 255);
int total_values_read = 0;
int batch_actual = 0;
int levels_actual = 0;
int64_t null_count = -1;
int64_t levels_read = 0;
int64_t values_read;
Int32Reader* reader = static_cast<Int32Reader*>(reader_.get());
int32_t batch_size = 8;
int batch = 0;
// This will cover both the cases
// 1) batch_size < page_size (multiple ReadBatch from a single page)
// 2) batch_size > page_size (BatchRead limits to a single page)
do {
ARROW_SUPPRESS_DEPRECATION_WARNING
batch = static_cast<int>(reader->ReadBatchSpaced(
batch_size, dresult.data() + levels_actual, rresult.data() + levels_actual,
vresult.data() + batch_actual, valid_bits.data() + batch_actual, 0,
&levels_read, &values_read, &null_count));
ARROW_UNSUPPRESS_DEPRECATION_WARNING
total_values_read += batch - static_cast<int>(null_count);
batch_actual += batch;
levels_actual += static_cast<int>(levels_read);
batch_size = std::min(1 << 24, std::max(batch_size * 2, 4096));
} while ((batch > 0) || (levels_read > 0));
ASSERT_EQ(num_levels_, levels_actual);
ASSERT_EQ(num_values_, total_values_read);
if (max_def_level_ > 0) {
ASSERT_TRUE(vector_equal(def_levels_, dresult));
ASSERT_TRUE(vector_equal_with_def_levels(values_, dresult, max_def_level_,
max_rep_level_, vresult));
} else {
ASSERT_TRUE(vector_equal(values_, vresult));
}
if (max_rep_level_ > 0) {
ASSERT_TRUE(vector_equal(rep_levels_, rresult));
}
// catch improper writes at EOS
ARROW_SUPPRESS_DEPRECATION_WARNING
batch_actual = static_cast<int>(
reader->ReadBatchSpaced(5, nullptr, nullptr, nullptr, valid_bits.data(), 0,
&levels_read, &values_read, &null_count));
ARROW_UNSUPPRESS_DEPRECATION_WARNING
ASSERT_EQ(0, batch_actual);
ASSERT_EQ(0, null_count);
}
void Clear() {
values_.clear();
def_levels_.clear();
rep_levels_.clear();
pages_.clear();
reader_.reset();
}
void ExecutePlain(int num_pages, int levels_per_page, const ColumnDescriptor* d) {
num_values_ =
MakePages<Int32Type>(d, num_pages, levels_per_page, def_levels_, rep_levels_,
values_, data_buffer_, pages_, Encoding::PLAIN);
num_levels_ = num_pages * levels_per_page;
InitReader(d);
CheckResults();
Clear();
num_values_ =
MakePages<Int32Type>(d, num_pages, levels_per_page, def_levels_, rep_levels_,
values_, data_buffer_, pages_, Encoding::PLAIN);
num_levels_ = num_pages * levels_per_page;
InitReader(d);
CheckResultsSpaced();
Clear();
}
void ExecuteDict(int num_pages, int levels_per_page, const ColumnDescriptor* d) {
num_values_ =
MakePages<Int32Type>(d, num_pages, levels_per_page, def_levels_, rep_levels_,
values_, data_buffer_, pages_, Encoding::RLE_DICTIONARY);
num_levels_ = num_pages * levels_per_page;
InitReader(d);
CheckResults();
Clear();
num_values_ =
MakePages<Int32Type>(d, num_pages, levels_per_page, def_levels_, rep_levels_,
values_, data_buffer_, pages_, Encoding::RLE_DICTIONARY);
num_levels_ = num_pages * levels_per_page;
InitReader(d);
CheckResultsSpaced();
Clear();
}
protected:
int num_levels_;
int num_values_;
int16_t max_def_level_;
int16_t max_rep_level_;
std::vector<std::shared_ptr<Page>> pages_;
std::shared_ptr<ColumnReader> reader_;
std::vector<int32_t> values_;
std::vector<int16_t> def_levels_;
std::vector<int16_t> rep_levels_;
std::vector<uint8_t> data_buffer_; // For BA and FLBA
};
TEST_F(TestPrimitiveReader, TestInt32FlatRequired) {
int levels_per_page = 100;
int num_pages = 50;
max_def_level_ = 0;
max_rep_level_ = 0;
NodePtr type = schema::Int32("a", Repetition::REQUIRED);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
ASSERT_NO_FATAL_FAILURE(ExecutePlain(num_pages, levels_per_page, &descr));
ASSERT_NO_FATAL_FAILURE(ExecuteDict(num_pages, levels_per_page, &descr));
}
TEST_F(TestPrimitiveReader, TestInt32FlatOptional) {
int levels_per_page = 100;
int num_pages = 50;
max_def_level_ = 4;
max_rep_level_ = 0;
NodePtr type = schema::Int32("b", Repetition::OPTIONAL);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
ASSERT_NO_FATAL_FAILURE(ExecutePlain(num_pages, levels_per_page, &descr));
ASSERT_NO_FATAL_FAILURE(ExecuteDict(num_pages, levels_per_page, &descr));
}
TEST_F(TestPrimitiveReader, TestInt32FlatRepeated) {
int levels_per_page = 100;
int num_pages = 50;
max_def_level_ = 4;
max_rep_level_ = 2;
NodePtr type = schema::Int32("c", Repetition::REPEATED);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
ASSERT_NO_FATAL_FAILURE(ExecutePlain(num_pages, levels_per_page, &descr));
ASSERT_NO_FATAL_FAILURE(ExecuteDict(num_pages, levels_per_page, &descr));
}
// Tests skipping around page boundaries.
TEST_F(TestPrimitiveReader, TestSkipAroundPageBoundries) {
int levels_per_page = 100;
int num_pages = 7;
max_def_level_ = 0;
max_rep_level_ = 0;
NodePtr type = schema::Int32("b", Repetition::REQUIRED);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
MakePages<Int32Type>(&descr, num_pages, levels_per_page, def_levels_, rep_levels_,
values_, data_buffer_, pages_, Encoding::PLAIN);
InitReader(&descr);
std::vector<int32_t> vresult(levels_per_page / 2, -1);
std::vector<int16_t> dresult(levels_per_page / 2, -1);
std::vector<int16_t> rresult(levels_per_page / 2, -1);
Int32Reader* reader = static_cast<Int32Reader*>(reader_.get());
int64_t values_read = 0;
// 1) skip_size > page_size (multiple pages skipped)
// Skip first 2 pages
int64_t levels_skipped = reader->Skip(2 * levels_per_page);
ASSERT_EQ(2 * levels_per_page, levels_skipped);
// Read half a page
reader->ReadBatch(levels_per_page / 2, dresult.data(), rresult.data(), vresult.data(),
&values_read);
std::vector<int32_t> sub_values(
values_.begin() + 2 * levels_per_page,
values_.begin() + static_cast<int>(2.5 * levels_per_page));
ASSERT_TRUE(vector_equal(sub_values, vresult));
// 2) skip_size == page_size (skip across two pages from page 2.5 to 3.5)
levels_skipped = reader->Skip(levels_per_page);
ASSERT_EQ(levels_per_page, levels_skipped);
// Read half a page (page 3.5 to 4)
reader->ReadBatch(levels_per_page / 2, dresult.data(), rresult.data(), vresult.data(),
&values_read);
sub_values.clear();
sub_values.insert(sub_values.end(),
values_.begin() + static_cast<int>(3.5 * levels_per_page),
values_.begin() + 4 * levels_per_page);
ASSERT_TRUE(vector_equal(sub_values, vresult));
// 3) skip_size == page_size (skip page 4 from start of the page to the end)
levels_skipped = reader->Skip(levels_per_page);
ASSERT_EQ(levels_per_page, levels_skipped);
// Read half a page (page 5 to 5.5)
reader->ReadBatch(levels_per_page / 2, dresult.data(), rresult.data(), vresult.data(),
&values_read);
sub_values.clear();
sub_values.insert(sub_values.end(),
values_.begin() + static_cast<int>(5.0 * levels_per_page),
values_.begin() + static_cast<int>(5.5 * levels_per_page));
ASSERT_TRUE(vector_equal(sub_values, vresult));
// 4) skip_size < page_size (skip limited to a single page)
// Skip half a page (page 5.5 to 6)
levels_skipped = reader->Skip(levels_per_page / 2);
ASSERT_EQ(0.5 * levels_per_page, levels_skipped);
// Read half a page (6 to 6.5)
reader->ReadBatch(levels_per_page / 2, dresult.data(), rresult.data(), vresult.data(),
&values_read);
sub_values.clear();
sub_values.insert(sub_values.end(),
values_.begin() + static_cast<int>(6.0 * levels_per_page),
values_.begin() + static_cast<int>(6.5 * levels_per_page));
ASSERT_TRUE(vector_equal(sub_values, vresult));
// 5) skip_size = 0
levels_skipped = reader->Skip(0);
ASSERT_EQ(0, levels_skipped);
// 6) Skip past the end page.
levels_skipped = reader->Skip(levels_per_page / 2 + 10);
ASSERT_EQ(levels_per_page / 2, levels_skipped);
values_.clear();
def_levels_.clear();
rep_levels_.clear();
pages_.clear();
reader_.reset();
}
// Skip with repeated field. This test makes it clear that we are skipping
// values and not records.
TEST_F(TestPrimitiveReader, TestSkipRepeatedField) {
// Example schema: message M { repeated int32 b = 1 }
max_def_level_ = 1;
max_rep_level_ = 1;
NodePtr type = schema::Int32("b", Repetition::REPEATED);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
// Example rows: {}, {[10, 10]}, {[20, 20, 20]}
std::vector<int32_t> values = {10, 10, 20, 20, 20};
std::vector<int16_t> def_levels = {0, 1, 1, 1, 1, 1};
std::vector<int16_t> rep_levels = {0, 0, 1, 0, 1, 1};
num_values_ = static_cast<int>(def_levels.size());
std::shared_ptr<DataPageV1> page = MakeDataPage<Int32Type>(
&descr, values, num_values_, Encoding::PLAIN, /*indices=*/{},
/*indices_size=*/0, def_levels, max_def_level_, rep_levels, max_rep_level_);
pages_.push_back(std::move(page));
InitReader(&descr);
Int32Reader* reader = static_cast<Int32Reader*>(reader_.get());
// Vecotrs to hold read values, definition levels, and repetition levels.
std::vector<int32_t> read_vals(4, -1);
std::vector<int16_t> read_defs(4, -1);
std::vector<int16_t> read_reps(4, -1);
// Skip two levels.
int64_t levels_skipped = reader->Skip(2);
ASSERT_EQ(2, levels_skipped);
int64_t num_read_values = 0;
// Read the next set of values
reader->ReadBatch(10, read_defs.data(), read_reps.data(), read_vals.data(),
&num_read_values);
ASSERT_EQ(num_read_values, 4);
// Note that we end up in the record with {[10, 10]}
ASSERT_TRUE(vector_equal({10, 20, 20, 20}, read_vals));
ASSERT_TRUE(vector_equal({1, 1, 1, 1}, read_defs));
ASSERT_TRUE(vector_equal({1, 0, 1, 1}, read_reps));
// No values remain in data page
levels_skipped = reader->Skip(2);
ASSERT_EQ(0, levels_skipped);
reader->ReadBatch(10, read_defs.data(), read_reps.data(), read_vals.data(),
&num_read_values);
ASSERT_EQ(num_read_values, 0);
}
// Page claims to have two values but only 1 is present.
TEST_F(TestPrimitiveReader, TestReadValuesMissing) {
max_def_level_ = 1;
max_rep_level_ = 0;
constexpr int batch_size = 1;
std::vector<bool> values(1, false);
std::vector<int16_t> input_def_levels(1, 1);
NodePtr type = schema::Boolean("a", Repetition::OPTIONAL);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
// The data page falls back to plain encoding
std::shared_ptr<ResizableBuffer> dummy = AllocateBuffer();
std::shared_ptr<DataPageV1> data_page = MakeDataPage<BooleanType>(
&descr, values, /*num_values=*/2, Encoding::PLAIN, /*indices=*/{},
/*indices_size=*/0, /*def_levels=*/input_def_levels, max_def_level_,
/*rep_levels=*/{},
/*max_rep_level=*/0);
pages_.push_back(data_page);
InitReader(&descr);
auto reader = static_cast<BoolReader*>(reader_.get());
ASSERT_TRUE(reader->HasNext());
std::vector<int16_t> def_levels(batch_size, 0);
std::vector<int16_t> rep_levels(batch_size, 0);
bool values_out[batch_size];
int64_t values_read;
EXPECT_EQ(1, reader->ReadBatch(batch_size, def_levels.data(), rep_levels.data(),
values_out, &values_read));
ASSERT_THROW(reader->ReadBatch(batch_size, def_levels.data(), rep_levels.data(),
values_out, &values_read),
ParquetException);
}
// Repetition level byte length reported in Page but Max Repetition level
// is zero for the column.
TEST_F(TestPrimitiveReader, TestRepetitionLvlBytesWithMaxRepetitionZero) {
constexpr int batch_size = 4;
max_def_level_ = 1;
max_rep_level_ = 0;
NodePtr type = schema::Int32("a", Repetition::OPTIONAL);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
// Bytes here came from the example parquet file in ARROW-17453's int32
// column which was delta bit-packed. The key part is the first three
// bytes: the page header reports 1 byte for repetition levels even
// though the max rep level is 0. If that byte isn't skipped then
// we get def levels of [1, 1, 0, 0] instead of the correct [1, 1, 1, 0].
const std::vector<uint8_t> page_data{0x3, 0x3, 0x7, 0x80, 0x1, 0x4, 0x3,
0x18, 0x1, 0x2, 0x0, 0x0, 0x0, 0xc,
0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0};
std::shared_ptr<DataPageV2> data_page =
std::make_shared<DataPageV2>(Buffer::Wrap(page_data.data(), page_data.size()), 4, 1,
4, Encoding::DELTA_BINARY_PACKED, 2, 1, 21);
pages_.push_back(data_page);
InitReader(&descr);
auto reader = static_cast<Int32Reader*>(reader_.get());
int16_t def_levels_out[batch_size];
int32_t values[batch_size];
int64_t values_read;
ASSERT_TRUE(reader->HasNext());
EXPECT_EQ(4, reader->ReadBatch(batch_size, def_levels_out, /*replevels=*/nullptr,
values, &values_read));
EXPECT_EQ(3, values_read);
}
// Page claims to have two values but only 1 is present.
TEST_F(TestPrimitiveReader, TestReadValuesMissingWithDictionary) {
constexpr int batch_size = 1;
max_def_level_ = 1;
max_rep_level_ = 0;
NodePtr type = schema::Int32("a", Repetition::OPTIONAL);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
std::shared_ptr<ResizableBuffer> dummy = AllocateBuffer();
std::shared_ptr<DictionaryPage> dict_page =
std::make_shared<DictionaryPage>(dummy, 0, Encoding::PLAIN);
std::vector<int16_t> input_def_levels(1, 0);
std::shared_ptr<DataPageV1> data_page = MakeDataPage<Int32Type>(
&descr, {}, /*num_values=*/2, Encoding::RLE_DICTIONARY, /*indices=*/{},
/*indices_size=*/0, /*def_levels=*/input_def_levels, max_def_level_,
/*rep_levels=*/{},
/*max_rep_level=*/0);
pages_.push_back(dict_page);
pages_.push_back(data_page);
InitReader(&descr);
auto reader = static_cast<ByteArrayReader*>(reader_.get());
const ByteArray* dict = nullptr;
int32_t dict_len = 0;
int64_t indices_read = 0;
int32_t indices[batch_size];
int16_t def_levels_out[batch_size];
ASSERT_TRUE(reader->HasNext());
EXPECT_EQ(1, reader->ReadBatchWithDictionary(batch_size, def_levels_out,
/*rep_levels=*/nullptr, indices,
&indices_read, &dict, &dict_len));
ASSERT_THROW(reader->ReadBatchWithDictionary(batch_size, def_levels_out,
/*rep_levels=*/nullptr, indices,
&indices_read, &dict, &dict_len),
ParquetException);
}
TEST_F(TestPrimitiveReader, TestDictionaryEncodedPages) {
max_def_level_ = 0;
max_rep_level_ = 0;
NodePtr type = schema::Int32("a", Repetition::REQUIRED);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
std::shared_ptr<ResizableBuffer> dummy = AllocateBuffer();
std::shared_ptr<DictionaryPage> dict_page =
std::make_shared<DictionaryPage>(dummy, 0, Encoding::PLAIN);
std::shared_ptr<DataPageV1> data_page = MakeDataPage<Int32Type>(
&descr, {}, 0, Encoding::RLE_DICTIONARY, {}, 0, {}, 0, {}, 0);
pages_.push_back(dict_page);
pages_.push_back(data_page);
InitReader(&descr);
// Tests Dict : PLAIN, Data : RLE_DICTIONARY
ASSERT_NO_THROW(reader_->HasNext());
pages_.clear();
dict_page = std::make_shared<DictionaryPage>(dummy, 0, Encoding::PLAIN_DICTIONARY);
data_page = MakeDataPage<Int32Type>(&descr, {}, 0, Encoding::PLAIN_DICTIONARY, {}, 0,
{}, 0, {}, 0);
pages_.push_back(dict_page);
pages_.push_back(data_page);
InitReader(&descr);
// Tests Dict : PLAIN_DICTIONARY, Data : PLAIN_DICTIONARY
ASSERT_NO_THROW(reader_->HasNext());
pages_.clear();
data_page = MakeDataPage<Int32Type>(&descr, {}, 0, Encoding::RLE_DICTIONARY, {}, 0, {},
0, {}, 0);
pages_.push_back(data_page);
InitReader(&descr);
// Tests dictionary page must occur before data page
ASSERT_THROW(reader_->HasNext(), ParquetException);
pages_.clear();
dict_page = std::make_shared<DictionaryPage>(dummy, 0, Encoding::DELTA_BYTE_ARRAY);
pages_.push_back(dict_page);
InitReader(&descr);
// Tests only RLE_DICTIONARY is supported
ASSERT_THROW(reader_->HasNext(), ParquetException);
pages_.clear();
std::shared_ptr<DictionaryPage> dict_page1 =
std::make_shared<DictionaryPage>(dummy, 0, Encoding::PLAIN_DICTIONARY);
std::shared_ptr<DictionaryPage> dict_page2 =
std::make_shared<DictionaryPage>(dummy, 0, Encoding::PLAIN);
pages_.push_back(dict_page1);
pages_.push_back(dict_page2);
InitReader(&descr);
// Column cannot have more than one dictionary
ASSERT_THROW(reader_->HasNext(), ParquetException);
pages_.clear();
data_page = MakeDataPage<Int32Type>(&descr, {}, 0, Encoding::DELTA_BYTE_ARRAY, {}, 0,
{}, 0, {}, 0);
pages_.push_back(data_page);
InitReader(&descr);
// unsupported encoding
ASSERT_THROW(reader_->HasNext(), ParquetException);
pages_.clear();
}
TEST_F(TestPrimitiveReader, TestDictionaryEncodedPagesWithExposeEncoding) {
max_def_level_ = 0;
max_rep_level_ = 0;
int levels_per_page = 100;
int num_pages = 5;
std::vector<int16_t> def_levels;
std::vector<int16_t> rep_levels;
std::vector<ByteArray> values;
std::vector<uint8_t> buffer;
NodePtr type = schema::ByteArray("a", Repetition::REQUIRED);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
// Fully dictionary encoded
MakePages<ByteArrayType>(&descr, num_pages, levels_per_page, def_levels, rep_levels,
values, buffer, pages_, Encoding::RLE_DICTIONARY);
InitReader(&descr);
auto reader = static_cast<ByteArrayReader*>(reader_.get());
const ByteArray* dict = nullptr;
int32_t dict_len = 0;
int64_t total_indices = 0;
int64_t indices_read = 0;
int64_t value_size = values.size();
auto indices = std::make_unique<int32_t[]>(value_size);
while (total_indices < value_size && reader->HasNext()) {
const ByteArray* tmp_dict = nullptr;
int32_t tmp_dict_len = 0;
EXPECT_NO_THROW(reader->ReadBatchWithDictionary(
value_size, /*def_levels=*/nullptr,
/*rep_levels=*/nullptr, indices.get() + total_indices, &indices_read, &tmp_dict,
&tmp_dict_len));
if (tmp_dict != nullptr) {
// Dictionary is read along with data
EXPECT_GT(indices_read, 0);
dict = tmp_dict;
dict_len = tmp_dict_len;
} else {
// Dictionary is not read when there's no data
EXPECT_EQ(indices_read, 0);
}
total_indices += indices_read;
}
EXPECT_EQ(total_indices, value_size);
for (int64_t i = 0; i < total_indices; ++i) {
EXPECT_LT(indices[i], dict_len);
EXPECT_EQ(dict[indices[i]].len, values[i].len);
EXPECT_EQ(memcmp(dict[indices[i]].ptr, values[i].ptr, values[i].len), 0);
}
pages_.clear();
}
TEST_F(TestPrimitiveReader, TestNonDictionaryEncodedPagesWithExposeEncoding) {
max_def_level_ = 0;
max_rep_level_ = 0;
int64_t value_size = 100;
std::vector<int32_t> values(value_size, 0);
NodePtr type = schema::Int32("a", Repetition::REQUIRED);
const ColumnDescriptor descr(type, max_def_level_, max_rep_level_);
// The data page falls back to plain encoding
std::shared_ptr<ResizableBuffer> dummy = AllocateBuffer();
std::shared_ptr<DictionaryPage> dict_page =
std::make_shared<DictionaryPage>(dummy, 0, Encoding::PLAIN);
std::shared_ptr<DataPageV1> data_page = MakeDataPage<Int32Type>(
&descr, values, static_cast<int>(value_size), Encoding::PLAIN, /*indices=*/{},
/*indices_size=*/0, /*def_levels=*/{}, /*max_def_level=*/0, /*rep_levels=*/{},
/*max_rep_level=*/0);
pages_.push_back(dict_page);
pages_.push_back(data_page);
InitReader(&descr);
auto reader = static_cast<ByteArrayReader*>(reader_.get());
const ByteArray* dict = nullptr;
int32_t dict_len = 0;
int64_t indices_read = 0;
auto indices = std::make_unique<int32_t[]>(value_size);
// Dictionary cannot be exposed when it's not fully dictionary encoded
EXPECT_THROW(reader->ReadBatchWithDictionary(value_size, /*def_levels=*/nullptr,
/*rep_levels=*/nullptr, indices.get(),
&indices_read, &dict, &dict_len),
ParquetException);
pages_.clear();
}
class RecordReaderTest : public ::testing::Test {
public:
const int32_t kNullValue = -1;
void Init(int32_t max_def_level, int32_t max_rep_level, Repetition::type repetition) {
level_info_.def_level = max_def_level;
level_info_.rep_level = max_rep_level;
repetition_type_ = repetition;
NodePtr type = schema::Int32("b", repetition);
descr_ = std::make_unique<ColumnDescriptor>(type, level_info_.def_level,
level_info_.rep_level);
record_reader_ = internal::RecordReader::Make(descr_.get(), level_info_);
}
void CheckReadValues(std::vector<int32_t> expected_values,
std::vector<int16_t> expected_defs,
std::vector<int16_t> expected_reps) {
const auto read_values = reinterpret_cast<const int32_t*>(record_reader_->values());
std::vector<int32_t> read_vals(read_values,
read_values + record_reader_->values_written());
ASSERT_EQ(read_vals.size(), expected_values.size());
for (size_t i = 0; i < expected_values.size(); ++i) {
if (expected_values[i] != kNullValue) {
ASSERT_EQ(expected_values[i], read_values[i]);
}
}
if (repetition_type_ != Repetition::REQUIRED) {
std::vector<int16_t> read_defs(
record_reader_->def_levels(),
record_reader_->def_levels() + record_reader_->levels_position());
ASSERT_TRUE(vector_equal(expected_defs, read_defs));
}
if (repetition_type_ == Repetition::REPEATED) {
std::vector<int16_t> read_reps(
record_reader_->rep_levels(),
record_reader_->rep_levels() + record_reader_->levels_position());
ASSERT_TRUE(vector_equal(expected_reps, read_reps));
}
}
void CheckState(int64_t values_written, int64_t null_count, int64_t levels_written,
int64_t levels_position) {
ASSERT_EQ(record_reader_->values_written(), values_written);
ASSERT_EQ(record_reader_->null_count(), null_count);
ASSERT_EQ(record_reader_->levels_written(), levels_written);
ASSERT_EQ(record_reader_->levels_position(), levels_position);
}
protected:
std::shared_ptr<internal::RecordReader> record_reader_;
std::unique_ptr<ColumnDescriptor> descr_;
internal::LevelInfo level_info_;
Repetition::type repetition_type_;
};
// Tests reading a repeated field using the RecordReader.
TEST_F(RecordReaderTest, BasicReadRepeatedField) {
Init(/*max_def_level=*/1, /*max_rep_level=*/1, Repetition::REPEATED);
// Records look like: {[10], null, [20, 20], null, [30, 30, 30], null}
std::vector<std::shared_ptr<Page>> pages;
std::vector<int32_t> values = {10, 20, 20, 30, 30, 30};
std::vector<int16_t> def_levels = {1, 0, 1, 1, 0, 1, 1, 1, 0};
std::vector<int16_t> rep_levels = {0, 0, 0, 1, 0, 0, 1, 1, 0};
std::shared_ptr<DataPageV1> page = MakeDataPage<Int32Type>(
descr_.get(), values, /*num_values=*/static_cast<int>(def_levels.size()),
Encoding::PLAIN,
/*indices=*/{},
/*indices_size=*/0, def_levels, level_info_.def_level, rep_levels,
level_info_.rep_level);
pages.push_back(std::move(page));
auto pager = std::make_unique<MockPageReader>(pages);
record_reader_->SetPageReader(std::move(pager));
// Read [10], null
int64_t records_read = record_reader_->ReadRecords(/*num_records=*/2);
ASSERT_EQ(records_read, 2);
CheckState(/*values_written=*/2, /*null_count=*/1, /*levels_written=*/9,
/*levels_position=*/2);
CheckReadValues(/*expected_values=*/{10, kNullValue}, /*expected_defs=*/{1, 0},
/*expected_reps=*/{0, 0});
record_reader_->Reset();
CheckState(/*values_written=*/0, /*null_count=*/0, /*levels_written=*/7,
/*levels_position=*/0);
// Read [20, 20], null, [30, 30, 30]
records_read = record_reader_->ReadRecords(/*num_records=*/3);
ASSERT_EQ(records_read, 3);
CheckState(/*values_written=*/6, /*null_count=*/1, /*levels_written=*/7,
/*levels_position=*/6);
CheckReadValues(/*expected_values=*/{20, 20, kNullValue, 30, 30, 30},
/*expected_defs=*/{1, 1, 0, 1, 1, 1},
/*expected_reps=*/{0, 1, 0, 0, 1, 1});
record_reader_->Reset();
CheckState(/*values_written=*/0, /*null_count=*/0, /*levels_written=*/1,
/*levels_position=*/0);
// Read the last null value and read past the end.
records_read = record_reader_->ReadRecords(/*num_records=*/3);
ASSERT_EQ(records_read, 1);
CheckState(/*values_written=*/1, /*null_count=*/1, /*levels_written=*/1,
/*levels_position=*/1);
CheckReadValues(/*expected_values=*/{kNullValue},
/*expected_defs=*/{0},
/*expected_reps=*/{0});
record_reader_->Reset();
CheckState(/*values_written=*/0, /*null_count=*/0, /*levels_written=*/0,
/*levels_position=*/0);
}
// Test that we can skip required top level field.
TEST_F(RecordReaderTest, SkipRequiredTopLevel) {
Init(/*max_def_level=*/0, /*max_rep_level=*/0, Repetition::REQUIRED);
std::vector<std::shared_ptr<Page>> pages;
std::vector<int32_t> values = {10, 20, 20, 30, 30, 30};
std::shared_ptr<DataPageV1> page = MakeDataPage<Int32Type>(
descr_.get(), values, /*num_values=*/static_cast<int>(values.size()),
Encoding::PLAIN,
/*indices=*/{},
/*indices_size=*/0, /*def_levels=*/{}, level_info_.def_level,
/*rep_levels=*/{}, level_info_.rep_level);
pages.push_back(std::move(page));
auto pager = std::make_unique<MockPageReader>(pages);
record_reader_->SetPageReader(std::move(pager));
int64_t records_skipped = record_reader_->SkipRecords(/*num_records=*/3);
ASSERT_EQ(records_skipped, 3);
CheckState(/*values_written=*/0, /*null_count=*/0, /*levels_written=*/0,
/*levels_position=*/0);
int64_t records_read = record_reader_->ReadRecords(/*num_records=*/2);
ASSERT_EQ(records_read, 2);
CheckState(/*values_written=*/2, /*null_count=*/0, /*levels_written=*/0,
/*levels_position=*/0);
CheckReadValues(/*expected_values=*/{30, 30}, /*expected_defs=*/{},
/*expected_reps=*/{});
record_reader_->Reset();
CheckState(/*values_written=*/0, /*null_count=*/0, /*levels_written=*/0,
/*levels_position=*/0);
}
// Skip an optional field. Intentionally included some null values.
TEST_F(RecordReaderTest, SkipOptional) {
Init(/*max_def_level=*/1, /*max_rep_level=*/0, Repetition::OPTIONAL);
// Records look like {null, 10, 20, 30, null, 40, 50, 60}
std::vector<std::shared_ptr<Page>> pages;
std::vector<int32_t> values = {10, 20, 30, 40, 50, 60};
std::vector<int16_t> def_levels = {0, 1, 1, 0, 1, 1, 1, 1};
std::shared_ptr<DataPageV1> page = MakeDataPage<Int32Type>(
descr_.get(), values, /*num_values=*/static_cast<int>(values.size()),
Encoding::PLAIN,
/*indices=*/{},
/*indices_size=*/0, def_levels, level_info_.def_level,
/*rep_levels=*/{}, level_info_.rep_level);
pages.push_back(std::move(page));
auto pager = std::make_unique<MockPageReader>(pages);
record_reader_->SetPageReader(std::move(pager));
{
// Skip {null, 10}
// This also tests when we start with a Skip.
int64_t records_skipped = record_reader_->SkipRecords(/*num_records=*/2);
ASSERT_EQ(records_skipped, 2);
CheckState(/*values_written=*/0, /*null_count=*/0, /*levels_written=*/0,
/*levels_position=*/0);
}
{
// Read 3 records: {20, null, 30}
int64_t records_read = record_reader_->ReadRecords(/*num_records=*/3);
ASSERT_EQ(records_read, 3);
// values_written() includes null values.
// We had skipped 2 of the levels above. So there is only 6 left in total to
// read, and we read 3 of them here.
CheckState(/*values_written=*/3, /*null_count=*/1, /*levels_written=*/6,
/*levels_position=*/3);
// ReadRecords for optional fields uses ReadValuesSpaced, so there is a
// placeholder for null.
CheckReadValues(/*expected_values=*/{20, kNullValue, 30}, /*expected_defs=*/{1, 0, 1},
/*expected_reps=*/{});
}
{
// Skip {40, 50}.
int64_t records_skipped = record_reader_->SkipRecords(/*num_records=*/2);
ASSERT_EQ(records_skipped, 2);
CheckState(/*values_written=*/3, /*null_count=*/1, /*levels_written=*/4,
/*levels_position=*/3);
CheckReadValues(/*expected_values=*/{20, kNullValue, 30}, /*expected_defs=*/{1, 0, 1},
/*expected_reps=*/{});
// Reset after a Skip.
record_reader_->Reset();
CheckState(/*values_written=*/0, /*null_count=*/0, /*levels_written=*/1,
/*levels_position=*/0);
}
{
// Read to the end of the column. Read {60}
// This test checks that ReadAndThrowAwayValues works, since if it
// does not we would read the wrong values.
int64_t records_read = record_reader_->ReadRecords(/*num_records=*/1);
ASSERT_EQ(records_read, 1);
CheckState(/*values_written=*/1, /*null_count=*/0, /*levels_written=*/1,
/*levels_position=*/1);
CheckReadValues(/*expected_values=*/{60},
/*expected_defs=*/{1},
/*expected_reps=*/{});
}
// We have exhausted all the records.
ASSERT_EQ(record_reader_->ReadRecords(/*num_records=*/3), 0);
ASSERT_EQ(record_reader_->SkipRecords(/*num_records=*/3), 0);
}
// Test skipping for repeated fields.
TEST_F(RecordReaderTest, SkipRepeated) {
Init(/*max_def_level=*/1, /*max_rep_level=*/1, Repetition::REPEATED);
// Records look like {null, [20, 20, 20], null, [30, 30], [40]}
std::vector<std::shared_ptr<Page>> pages;
std::vector<int32_t> values = {20, 20, 20, 30, 30, 40};
std::vector<int16_t> def_levels = {0, 1, 1, 1, 0, 1, 1, 1};
std::vector<int16_t> rep_levels = {0, 0, 1, 1, 0, 0, 1, 0};
std::shared_ptr<DataPageV1> page = MakeDataPage<Int32Type>(
descr_.get(), values, /*num_values=*/static_cast<int>(values.size()),
Encoding::PLAIN,
/*indices=*/{},
/*indices_size=*/0, def_levels, level_info_.def_level, rep_levels,
level_info_.rep_level);
pages.push_back(std::move(page));
auto pager = std::make_unique<MockPageReader>(pages);
record_reader_->SetPageReader(std::move(pager));
{
// This should skip the first null record.
int64_t records_skipped = record_reader_->SkipRecords(/*num_records=*/1);
ASSERT_EQ(records_skipped, 1);
ASSERT_EQ(record_reader_->values_written(), 0);
ASSERT_EQ(record_reader_->null_count(), 0);
// For repeated fields, we need to read the levels to find the record
// boundaries and skip. So some levels are read, however, the skipped
// level should not be there after the skip. That's why levels_position()
// is 0.
CheckState(/*values_written=*/0, /*null_count=*/0, /*levels_written=*/7,
/*levels_position=*/0);
CheckReadValues(/*expected_values=*/{},
/*expected_defs=*/{},
/*expected_reps=*/{});
}
{
// Read [20, 20, 20]
int64_t records_read = record_reader_->ReadRecords(/*num_records=*/1);
ASSERT_EQ(records_read, 1);
CheckState(/*values_written=*/3, /*null_count=*/0, /*levels_written=*/7,
/*levels_position=*/3);
CheckReadValues(/*expected_values=*/{20, 20, 20},
/*expected_defs=*/{1, 1, 1},
/*expected_reps=*/{0, 1, 1});
}
{
// Skip the null record and also skip [30, 30]
int64_t records_skipped = record_reader_->SkipRecords(/*num_records=*/2);
ASSERT_EQ(records_skipped, 2);
// We remove the skipped levels from the buffer.
CheckState(/*values_written=*/3, /*null_count=*/0, /*levels_written=*/4,
/*levels_position=*/3);
CheckReadValues(/*expected_values=*/{20, 20, 20},
/*expected_defs=*/{1, 1, 1},
/*expected_reps=*/{0, 1, 1});
}
{
// Read [40]
int64_t records_read = record_reader_->ReadRecords(/*num_records=*/1);
ASSERT_EQ(records_read, 1);
CheckState(/*values_written=*/4, /*null_count=*/0, /*levels_written=*/4,
/*levels_position=*/4);
CheckReadValues(/*expected_values=*/{20, 20, 20, 40},
/*expected_defs=*/{1, 1, 1, 1},
/*expected_reps=*/{0, 1, 1, 0});
}
}
// Tests that for repeated fields, we first consume what is in the buffer
// before reading more levels.
TEST_F(RecordReaderTest, SkipRepeatedConsumeBufferFirst) {
Init(/*max_def_level=*/1, /*max_rep_level=*/1, Repetition::REPEATED);
std::vector<std::shared_ptr<Page>> pages;
std::vector<int32_t> values(2048, 10);
std::vector<int16_t> def_levels(2048, 1);
std::vector<int16_t> rep_levels(2048, 0);
std::shared_ptr<DataPageV1> page = MakeDataPage<Int32Type>(
descr_.get(), values, /*num_values=*/static_cast<int>(values.size()),
Encoding::PLAIN,
/*indices=*/{},
/*indices_size=*/0, def_levels, level_info_.def_level, rep_levels,
level_info_.rep_level);
pages.push_back(std::move(page));
auto pager = std::make_unique<MockPageReader>(pages);
record_reader_->SetPageReader(std::move(pager));
{
// Read 1000 records. We will read 1024 levels because that is the minimum
// number of levels to read.
int64_t records_read = record_reader_->ReadRecords(/*num_records=*/1000);
ASSERT_EQ(records_read, 1000);
CheckState(/*values_written=*/1000, /*null_count=*/0, /*levels_written=*/1024,
/*levels_position=*/1000);
std::vector<int32_t> expected_values(1000, 10);
std::vector<int16_t> expected_def_levels(1000, 1);
std::vector<int16_t> expected_rep_levels(1000, 0);
CheckReadValues(expected_values, expected_def_levels, expected_rep_levels);
// Reset removes the already consumed values and levels.
record_reader_->Reset();
}
{ // Skip 12 records. Since we already have 24 in the buffer, we should not be
// reading any more levels into the buffer, we will just consume 12 of it.
int64_t records_skipped = record_reader_->SkipRecords(/*num_records=*/12);
ASSERT_EQ(records_skipped, 12);
CheckState(/*values_written=*/0, /*null_count=*/0, /*levels_written=*/12,
/*levels_position=*/0);
// Everthing is empty because we reset the reader before this skip.
CheckReadValues(/*expected_values=*/{}, /*expected_def_levels=*/{},
/*expected_rep_levels=*/{});
}
}
// Test reading when one record spans multiple pages for a repeated field.
TEST_F(RecordReaderTest, ReadPartialRecord) {
Init(/*max_def_level=*/1, /*max_rep_level=*/1, Repetition::REPEATED);
std::vector<std::shared_ptr<Page>> pages;
// Page 1: {[10], [20, 20, 20 ... } continues to next page.
{
std::shared_ptr<DataPageV1> page = MakeDataPage<Int32Type>(
descr_.get(), /*values=*/{10, 20, 20, 20}, /*num_values=*/4, Encoding::PLAIN,
/*indices=*/{},
/*indices_size=*/0, /*def_levels=*/{1, 1, 1, 1}, level_info_.def_level,
/*rep_levels=*/{0, 0, 1, 1}, level_info_.rep_level);