Skip to content

Fixed Get() method#7

Closed
10MINT wants to merge 1 commit intoOpenSourceAIX:masterfrom
10MINT:master
Closed

Fixed Get() method#7
10MINT wants to merge 1 commit intoOpenSourceAIX:masterfrom
10MINT:master

Conversation

@10MINT
Copy link
Contributor

@10MINT 10MINT commented Sep 25, 2018

See #6
PS: I don't know why GitHub also selected my other commits which have already been merged

@ColinTree
Copy link
Member

I think you may need to try updating your fork and then push PR with new branches.

Although resolving conflict and then squash & merge would ignore the existing commits, it is still more formal to create bug fix base on branch master.

Thanks for your contribution anyway!

@ColinTree
Copy link
Member

ColinTree commented Sep 25, 2018

Try this:

git add remote opensourceaix https://github.com/OpenSourceAIX/ColinTreeListView.git
git fetch opensourceaix
git reset --soft opensourceaix/master
git commit -am "commit message"
git push -f

This may works

@10MINT
Copy link
Contributor Author

10MINT commented Sep 25, 2018

Thanks, it worked, but the first command was
git remote add opensourceaix https://github.com/OpenSourceAIX/ColinTreeListView.git

@ColinTree
Copy link
Member

Hi there, just want to merge and suddenly found that your commit seems have some problem.
It rewrites the whole repository line by line, even the LICENSE is changed...
Could you try to fix that commit so that I can merge it safely?

@10MINT
Copy link
Contributor Author

10MINT commented Oct 6, 2018

I don't know what's wrong with my repo, I guess it would be best that you make the changes (it's only two lines) and I refork again.
grafik
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants