added Get function to retrieve the list#1
Merged
ColinTree merged 3 commits intoOpenSourceAIX:masterfrom Jun 24, 2018
Merged
Conversation
Contributor
Author
|
I also added get lastLongClickedElement functionality |
ColinTree
requested changes
Jun 24, 2018
ColinTreeListView.java
Outdated
| //returns the list of the listview | ||
| @SimpleFunction | ||
| public YailList Get() { | ||
| ArrayList stringRepresentation = new ArrayList(); |
Member
There was a problem hiding this comment.
Try to use ArrayList<?> instead of using raw type directly.
ColinTreeListView.java
Outdated
| public YailList Get() { | ||
| ArrayList stringRepresentation = new ArrayList(); | ||
| for (Element elem : elementList) { | ||
| stringRepresentation.add(YailList.YailListElementToString(elem.toYailList())); |
Member
There was a problem hiding this comment.
Why the elements are added as string here? I would prefer to make it YailList.
Member
|
@10MINT |
Contributor
Author
|
Is this ok, or should I change it to ArrayList<?>? |
Member
|
Merged. Thanks for your work 😉 |
Contributor
Author
|
Bugfix in 412832b because Get() returns the full list, including the hidden elements. Merge the changes if you do not want this behaviour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really appreciate your work and that you make it open source. I added the functionality to retrieve the list that is currently set