-
Notifications
You must be signed in to change notification settings - Fork 142
feat: add "Becoming a Maintainer" course #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… minor wording adjustments
… minor wording adjustments
…/add-maintainer-course
✅ Deploy Preview for sauced-intro ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 LGTM 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 |
docs/becoming-a-maintainer/README.md
Outdated
| <div align="center" style="text-align: center;"> | ||
| <div style="display: flex; align-items: center; justify-content: center;"> | ||
| <img alt="" src="../_assets/images/pizza-slice.png" width="100" height="100" style="margin-right: 5px;"> | ||
| <h1 style="margin: 0 0;">Becoming a Maintainer with <span style="background: linear-gradient(to right, #e74c3c, #e67e22); -webkit-background-clip: text; color: transparent;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BekahHW, there are a few of things here that I need your thought:
-
The styling for the header here and on the Intro course is far from the homepage, the font size-wise.
I played around with this style to make it closer to the homepage for consistency. But I don't commit it because I want you to test it out first and see if you're okay with it.
Below is the code:
Suggested change<h1 style="margin: 0 0;">Becoming a Maintainer with <span style="background: linear-gradient(to right, #e74c3c, #e67e22); -webkit-background-clip: text; color: transparent;"> <h1 style="font-size: 2.5em; font-family: 'Arial', sans-serif; font-weight: bold; margin: 25px 0;">Becoming a Maintainer with <span style="background: linear-gradient(to right, #e74c3c, #e67e22); -webkit-background-clip: text; color: transparent;""> Note: The font size here is
2.5eminstead of3em, so it won't make the logo look much smaller compared to the font. -
If we want to go with the above suggestion, on the homepage README, the margin should also be
margin: 25px 0. The10pxis too tight when we open this course on mobile. And we need to apply it to the Intro course header as well. -
Just two cents. Do we want to have the logo at the course's title? I go back and forth, and I think we dont need the logo here because we already have it on the sidebar. Also, because it's taking the space (it has wide padding, I guess) and to be consistent with the homepage title, which don;t have any logo. Although on mobile, users won't see it unless they click the sidebar open.
I have to get ready for our trip, so I might not be able to respond until some time tonight, my time. I'll leave this to you to decide. Thank you!
Description
This PR adds the "Becoming a Maintainer" course with following changes:
becoming-a-maintainerfolder in thedocsdirectory.becoming-a-maintainerfolder..nojekyllfile into the root ofdocs.Related Tickets & Documents
Closes #169 #171
Mobile & Desktop Screenshots/Recordings
Before
After
Screen Recording
new.style.mp4
Steps to QA
Tier (staff will fill in)
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?