Skip to content

Conversation

@adiati98
Copy link
Collaborator

@adiati98 adiati98 commented Apr 25, 2024

Description

This PR adds the "Becoming a Maintainer" course with following changes:

  • Added a becoming-a-maintainer folder in the docs directory.
  • Moved the course's files from maintainer course repo to the becoming-a-maintainer folder.
  • Fixed links and adjusted wording to accomodate both courses.
  • Moved .nojekyll file into the root of docs.
  • Changed styling for accessibility purpose as shown in the screenshots. Color palettes are following OpenSauced's brand.

Related Tickets & Documents

Closes #169 #171

Mobile & Desktop Screenshots/Recordings

Before

Screenshot 2024-04-25 175137

Screenshot 2024-04-25 175114

After

Screenshot 2024-04-25 175042

Screenshot 2024-04-25 175012

Screen Recording

new.style.mp4

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@adiati98 adiati98 self-assigned this Apr 25, 2024
@adiati98 adiati98 requested a review from a team as a code owner April 25, 2024 15:59
@netlify
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for sauced-intro ready!

Name Link
🔨 Latest commit fc84e93
🔍 Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/662bc2241dc65a0008f361d2
😎 Deploy Preview https://deploy-preview-174--sauced-intro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BekahHW
Copy link
Contributor

BekahHW commented Apr 25, 2024

🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 LGTM 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀

<div align="center" style="text-align: center;">
<div style="display: flex; align-items: center; justify-content: center;">
<img alt="" src="../_assets/images/pizza-slice.png" width="100" height="100" style="margin-right: 5px;">
<h1 style="margin: 0 0;">Becoming a Maintainer with <span style="background: linear-gradient(to right, #e74c3c, #e67e22); -webkit-background-clip: text; color: transparent;">
Copy link
Collaborator Author

@adiati98 adiati98 Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BekahHW, there are a few of things here that I need your thought:

  1. The styling for the header here and on the Intro course is far from the homepage, the font size-wise.

    I played around with this style to make it closer to the homepage for consistency. But I don't commit it because I want you to test it out first and see if you're okay with it.

    Below is the code:

    Suggested change
    <h1 style="margin: 0 0;">Becoming a Maintainer with <span style="background: linear-gradient(to right, #e74c3c, #e67e22); -webkit-background-clip: text; color: transparent;">
    <h1 style="font-size: 2.5em; font-family: 'Arial', sans-serif; font-weight: bold; margin: 25px 0;">Becoming a Maintainer with <span style="background: linear-gradient(to right, #e74c3c, #e67e22); -webkit-background-clip: text; color: transparent;"">

    Note: The font size here is 2.5em instead of 3em, so it won't make the logo look much smaller compared to the font.

  2. If we want to go with the above suggestion, on the homepage README, the margin should also be margin: 25px 0. The 10px is too tight when we open this course on mobile. And we need to apply it to the Intro course header as well.

  3. Just two cents. Do we want to have the logo at the course's title? I go back and forth, and I think we dont need the logo here because we already have it on the sidebar. Also, because it's taking the space (it has wide padding, I guess) and to be consistent with the homepage title, which don;t have any logo. Although on mobile, users won't see it unless they click the sidebar open.

I have to get ready for our trip, so I might not be able to respond until some time tonight, my time. I'll leave this to you to decide. Thank you!

@BekahHW BekahHW merged commit 4b63c80 into main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add the maintainer course

3 participants